From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Biggers Subject: Re: [RFC PATCH 00/10] Consolidate Post read processing code Date: Thu, 21 Feb 2019 10:38:28 -0800 Message-ID: <20190221183827.GA140206@gmail.com> References: <20190218100433.20048-1-chandan@linux.ibm.com> <20190220004107.GI12177@gmail.com> <2420837.hecoV8S9Z6@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gwtF0-0002HP-VZ for linux-f2fs-devel@lists.sourceforge.net; Thu, 21 Feb 2019 18:38:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1gwtEy-005kJJ-8f for linux-f2fs-devel@lists.sourceforge.net; Thu, 21 Feb 2019 18:38:38 +0000 Content-Disposition: inline In-Reply-To: <2420837.hecoV8S9Z6@localhost.localdomain> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Chandan Rajendra Cc: tytso@mit.edu, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, adilger.kernel@dilger.ca, jaegeuk@kernel.org, linux-ext4@vger.kernel.org On Thu, Feb 21, 2019 at 07:02:03PM +0530, Chandan Rajendra wrote: > On Wednesday, February 20, 2019 6:11:07 AM IST Eric Biggers wrote: > > On Mon, Feb 18, 2019 at 03:34:23PM +0530, Chandan Rajendra wrote: > > > Based on the reviews provided for this patchset, I > > > will change F2FS to use mpage_readpage[s] and post the next version of > > > this patchset to linux-fsdevel mailing list. > > > > Is that really possible? F2FS has other functionality in its ->readpages(), > > such as support for filesystems that use multiple block devices. > > > > Hmm. I didn't know that. Thanks for pointing that out. I will read up that > code and if it isn't really possible to get F2FS to use mpage_readpage[s](), > then I would limit the patchset to Ext4. > But we can make F2FS use the shared bio_post_read functions even if it can't use mpage_readpage[s](), right? - Eric