From: Matthew Wilcox <willy@infradead.org>
To: sunqiuyang <sunqiuyang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, yuchao0@huawei.com
Subject: Re: [PATCH v4 1/1] f2fs: ioctl for removing a range from F2FS
Date: Wed, 22 May 2019 08:09:58 -0700 [thread overview]
Message-ID: <20190522150958.GC6738@bombadil.infradead.org> (raw)
In-Reply-To: <20190522040530.37886-1-sunqiuyang@huawei.com>
On Wed, May 22, 2019 at 12:05:30PM +0800, sunqiuyang wrote:
> +static int f2fs_ioc_resize_fs(struct file *filp, unsigned long arg)
> +{
> + struct f2fs_sb_info *sbi = F2FS_I_SB(file_inode(filp));
> + __u64 block_count;
> + int ret;
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EPERM;
> +
> + if (f2fs_readonly(sbi->sb))
> + return -EROFS;
> +
> + if (copy_from_user(&block_count, (__u64 __user *)arg, sizeof(__u64)))
> + return -EFAULT;
You can just call get_user() here.
prev parent reply other threads:[~2019-05-22 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 4:05 [PATCH v4 1/1] f2fs: ioctl for removing a range from F2FS sunqiuyang
2019-05-22 13:47 ` [f2fs-dev] " Chao Yu
2019-05-22 15:09 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522150958.GC6738@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunqiuyang@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).