From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Ts'o" Subject: Re: [PATCH v4 13/16] fs-verity: support builtin file signatures Date: Sat, 15 Jun 2019 11:21:43 -0400 Message-ID: <20190615152143.GN6142@mit.edu> References: <20190606155205.2872-1-ebiggers@kernel.org> <20190606155205.2872-14-ebiggers@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hcAVD-0006z5-LW for linux-f2fs-devel@lists.sourceforge.net; Sat, 15 Jun 2019 15:21:59 +0000 Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hcAVA-009NHD-LQ for linux-f2fs-devel@lists.sourceforge.net; Sat, 15 Jun 2019 15:21:58 +0000 Content-Disposition: inline In-Reply-To: <20190606155205.2872-14-ebiggers@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Eric Biggers Cc: "Darrick J . Wong" , linux-api@vger.kernel.org, Dave Chinner , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-integrity@vger.kernel.org, linux-ext4@vger.kernel.org, Linus Torvalds , Christoph Hellwig , Victor Hsieh On Thu, Jun 06, 2019 at 08:52:02AM -0700, Eric Biggers wrote: > From: Eric Biggers > > To meet some users' needs, add optional support for having fs-verity > handle a portion of the authentication policy in the kernel. An > ".fs-verity" keyring is created to which X.509 certificates can be > added; then a sysctl 'fs.verity.require_signatures' can be set to cause > the kernel to enforce that all fs-verity files contain a signature of > their file measurement by a key in this keyring. I think it might be a good idea to allow the require_signatures setting to be set on a per-file system basis, via a mount option? We could plumb it in via a flag in fsverity_info, set by the file system. Other than this feature request, looks good; you can add: Reviewed-off-by: Theodore Ts'o - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C65CEC31E50 for ; Sat, 15 Jun 2019 15:22:02 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9541C20868; Sat, 15 Jun 2019 15:22:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="MosT/W1o"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="QOk6mk7F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9541C20868 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hcAVG-0006zt-Ur; Sat, 15 Jun 2019 15:22:02 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hcAVD-0006z5-LW for linux-f2fs-devel@lists.sourceforge.net; Sat, 15 Jun 2019 15:21:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=i327xPUC9SVccJ5lgCHtt3wOYSJepgWAY0+Cl2iA8z0=; b=MosT/W1oD2FwOPTEmfTOnUg1F4 Iyzhf08e/JbSKxYLYhJik9ZpAbNPJLcP8rFAMEk+vd4t5333vyMZF4BfhB5QhAi6fDKx3/oJVtKth WReY4/sSRInkCyxLbTYI5KOAELFOO+gYXBvG/WOuoc+ngQZqpn6QekIQu79tjfQhsnQo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=i327xPUC9SVccJ5lgCHtt3wOYSJepgWAY0+Cl2iA8z0=; b=QOk6mk7FRXLPEnLrD7AHOfNRT6 wRp0xKFVrU3NW63IfgrWv21daD3tqKSwKCacapnTk4FfC1aUliGATTj8twMd34B4Pc8WPMDL0oZzD Oxb4AuLxG6zihGcXeHXteLz17qAVIshuenIF3UHSX9GcQ3Ddl4ywf+kqCiLIjLA2Hne0=; Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hcAVA-009NHD-LQ for linux-f2fs-devel@lists.sourceforge.net; Sat, 15 Jun 2019 15:21:58 +0000 Received: from callcc.thunk.org (rrcs-74-87-88-165.west.biz.rr.com [74.87.88.165]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x5FFLh4o009292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 15 Jun 2019 11:21:45 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 1D573420484; Sat, 15 Jun 2019 11:21:43 -0400 (EDT) Date: Sat, 15 Jun 2019 11:21:43 -0400 From: "Theodore Ts'o" To: Eric Biggers Message-ID: <20190615152143.GN6142@mit.edu> References: <20190606155205.2872-1-ebiggers@kernel.org> <20190606155205.2872-14-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190606155205.2872-14-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1hcAVA-009NHD-LQ Subject: Re: [f2fs-dev] [PATCH v4 13/16] fs-verity: support builtin file signatures X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Darrick J . Wong" , linux-api@vger.kernel.org, Dave Chinner , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-integrity@vger.kernel.org, linux-ext4@vger.kernel.org, Linus Torvalds , Christoph Hellwig , Victor Hsieh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Message-ID: <20190615152143.bSExAZfjddXfYE6o-tieAxStvNJxfoIrrVAFGsklxXI@z> On Thu, Jun 06, 2019 at 08:52:02AM -0700, Eric Biggers wrote: > From: Eric Biggers > > To meet some users' needs, add optional support for having fs-verity > handle a portion of the authentication policy in the kernel. An > ".fs-verity" keyring is created to which X.509 certificates can be > added; then a sysctl 'fs.verity.require_signatures' can be set to cause > the kernel to enforce that all fs-verity files contain a signature of > their file measurement by a key in this keyring. I think it might be a good idea to allow the require_signatures setting to be set on a per-file system basis, via a mount option? We could plumb it in via a flag in fsverity_info, set by the file system. Other than this feature request, looks good; you can add: Reviewed-off-by: Theodore Ts'o - Ted _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel