From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F194C31E5B for ; Tue, 18 Jun 2019 16:35:15 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2356F20673; Tue, 18 Jun 2019 16:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="RwAXfmrp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="TZ0APgSI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yo9Vew7B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2356F20673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hdH4n-0005KG-0X; Tue, 18 Jun 2019 16:35:17 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hdH4l-0005K8-Oq for linux-f2fs-devel@lists.sourceforge.net; Tue, 18 Jun 2019 16:35:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8DKgm6PrfnpRt8q5yz/6pwsS2FA2tAPr9IEJwXFoa0c=; b=RwAXfmrpQeDukRbvXFbAnIUotL YNgp1yLe+5KNgxV7QcZaCQ9ym0DjWyfpXW96uvGife1WODYgKyTZV2eCSrz02WAgDuXCKXqKd13Nl YIJ1uZvKqFuu+xI9XxV+IYIpRQdwSqKoH2Mjex5E/KHQJAdmSqmplY/fv1QpZ/v4LA7A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8DKgm6PrfnpRt8q5yz/6pwsS2FA2tAPr9IEJwXFoa0c=; b=TZ0APgSIAO7X7LAum33EA+qtNq 5BpUUCnc2JLCLefsSyGa5OfiKxRpJi524WWerBzpDprYviHR/luh7GMiae3zVr1g4lHon4URtgfsy KmkeyEO4E82+FAWtj/mmlA5xbtSV391o8fsFGanWfzOyNdGPx/yYkdbcGjp5WOb38fng=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hdH4i-003djt-0G for linux-f2fs-devel@lists.sourceforge.net; Tue, 18 Jun 2019 16:35:13 +0000 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0758720673; Tue, 18 Jun 2019 16:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560875706; bh=GeIvHcqxM8GaaYPQkIqVTtuvhdr1Xv+rCU27pAM0CSg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yo9Vew7Bm0+5tZyNbxb/SXmKNcf/bFXBgzKVl3flNIxOzH8wbcJTYEsVheeLxJoNA PwmDSlPYT48h693vme8664sJ0r3s1gRftmE9pqtaT1HaMiWQbV9OgBggVcgDorla1v aOgwjKhoYToWhR4vzNmuDK39hClHFyzbqh2cXHWA= Date: Tue, 18 Jun 2019 09:35:04 -0700 From: Eric Biggers To: Theodore Ts'o Message-ID: <20190618163503.GC184520@gmail.com> References: <20190606155205.2872-1-ebiggers@kernel.org> <20190606155205.2872-8-ebiggers@kernel.org> <20190615144207.GH6142@mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190615144207.GH6142@mit.edu> User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1hdH4i-003djt-0G Subject: Re: [f2fs-dev] [PATCH v4 07/16] fs-verity: add the hook for file ->open() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Darrick J . Wong" , linux-api@vger.kernel.org, Dave Chinner , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-integrity@vger.kernel.org, linux-ext4@vger.kernel.org, Linus Torvalds , Christoph Hellwig , Victor Hsieh Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Sat, Jun 15, 2019 at 10:42:07AM -0400, Theodore Ts'o wrote: > On Thu, Jun 06, 2019 at 08:51:56AM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > Add the fsverity_file_open() function, which prepares an fs-verity file > > to be read from. If not already done, it loads the fs-verity descriptor > > from the filesystem and sets up an fsverity_info structure for the inode > > which describes the Merkle tree and contains the file measurement. It > > also denies all attempts to open verity files for writing. > > > > This commit also begins the include/linux/fsverity.h header, which > > declares the interface between fs/verity/ and filesystems. > > > > Signed-off-by: Eric Biggers > > Looks good; you can add: > > Reviewed-off-by: Theodore Ts'o > > - Ted > > > +/* > > + * Validate the given fsverity_descriptor and create a new fsverity_info from > > + * it. The signature (if present) is also checked. > > + */ > > +struct fsverity_info *fsverity_create_info(const struct inode *inode, > > + const void *_desc, size_t desc_size) > > Well, technically it's not checked (yet). It doesn't get checked > until [PATCH 13/16]: support builtin file signatures. If we want to > be really nit-picky, that portion of the comment could be moved to > later in the series. > Yes, I missed this when splitting out the patches. I'll move it to patch 13. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel