From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC29EC433FF for ; Sun, 28 Jul 2019 09:51:58 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A68D12075E; Sun, 28 Jul 2019 09:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="XO+L+cqm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="ZHSD3Ts5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eG9clFKj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A68D12075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hrfqP-0006yk-Tt; Sun, 28 Jul 2019 09:51:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hrfqN-0006yW-P3 for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Jul 2019 09:51:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d8iNABSCoA76pmGK9qmPaGq65cJlxUTHLSDeA2aeOrA=; b=XO+L+cqmJFQwwUldoaep6aopiA 8PNTY3gj3mvWt6hbYtnpVk/eBwckedZvoprxgDWjcDSlMsDt39f13h59co3QBrJbxL1cMgG7xLqXS 4YFwD6A0G3hpuggOD0mNLkqL6U0a6AqC6VJDI3lQa9cEbXuOnHPuHp6Yi33R5o5rC5Dw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d8iNABSCoA76pmGK9qmPaGq65cJlxUTHLSDeA2aeOrA=; b=ZHSD3Ts5d6WI0lLODMJ+/+4/uU N96ZGWxO5Clu7nn+QjE0owx6in/4UlY3fiPe5SmVMyjodVlPUJXy3DI8NY4IZtvThQQL+AW+0YskP MwVBSszVkaFJ83ULQQNWzeEA5TyW9U0Ek+VuThOLcpjXCwEX31g3giNfgLj6WEevYoYw=; Received: from mail-pf1-f193.google.com ([209.85.210.193]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1hrfqM-00A2Nk-EE for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Jul 2019 09:51:55 +0000 Received: by mail-pf1-f193.google.com with SMTP id u14so26552675pfn.2 for ; Sun, 28 Jul 2019 02:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=d8iNABSCoA76pmGK9qmPaGq65cJlxUTHLSDeA2aeOrA=; b=eG9clFKjkjwtrelJY+QQiUECgI+8Bxiex/zXnX0aeWYz61ZKCPdqXyjdx+Kj+n5J9K 3ms/GdiunNPRZuFSkN4TMJX58MAZuXBw1fAwq0APa+H733EwtXzwTU3oBLaI85AWOOKm 2i3ihd8fgFwHo43icZ+8pdHv9STPBjcbcI2eFEW4VJYH5zeaN1DGVARC0GRAoDs4yuK+ etXK9UpqkT8gi6dlvFU32FoUmne1HxESzeiFVzXuzhGS0Dp5SR9XhXCMAic/mYK94kX+ YMPLv+6sjnjKXL0Adn4FoK0dEpG9JYl5h0+dTE1ujqbrbVhc8HWlJggMUqeoB3CfuJMJ vOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=d8iNABSCoA76pmGK9qmPaGq65cJlxUTHLSDeA2aeOrA=; b=qlAQGoUR/OBbwvv729KJai5AH7+mVWxjqgY7AXUeBMa/8b15rzjlbcakzjiybwrqFp eA+PvnVpyhxdLhgiZpccnxm6Av+S1ax2twVfDR2PIbShmLRSc06lEnoOOcWK1taPNd4p Ot5EpuL8we+k3c6vgrsDSSvFD46t27Mq/8r15EXF1IFAUUiCrT8i2h7e8CEYazFRi1UO BCs+ebAWEkzGiry3yU/8cXvi45tc0SZv6WKkBoGDCHBYbogTSnri+/g8UIi2IeUX1geD p6rG6+r4eBZezs3G1+m7tYLcSNdr6l4ku0jWxeCk6Xyj4oz9EkKjHIJ/JjJnpmDfCiwE 8h2Q== X-Gm-Message-State: APjAAAVGI+vh7VhL+2qzZHW/Svs6LLPfaHtnUuF3J67rkw5ARFxfup8o ZuebtwyyJNTd0ohZcZbKt/c= X-Google-Smtp-Source: APXvYqyIAK2pahg7qBTd2KJN/pZYK2Vu4MNbPTaOuqgx+CtE1M32/LB+lv8Mpj4v4Rz/Y4aDHXAsBQ== X-Received: by 2002:a63:a35e:: with SMTP id v30mr39657045pgn.129.1564307508628; Sun, 28 Jul 2019 02:51:48 -0700 (PDT) Received: from localhost ([178.128.102.47]) by smtp.gmail.com with ESMTPSA id q126sm14748715pfb.56.2019.07.28.02.51.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 28 Jul 2019 02:51:47 -0700 (PDT) Date: Sun, 28 Jul 2019 17:51:41 +0800 From: Eryu Guan To: Chao Yu Message-ID: <20190728095141.GM7943@desktop> References: <20190723092529.112426-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190723092529.112426-1-yuchao0@huawei.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-Headers-End: 1hrfqM-00A2Nk-EE Subject: Re: [f2fs-dev] [PATCH 1/3] generic/38[3456]: adjust to check prjquota before mount X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jaegeuk@kernel.org, chao@kernel.orga, fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Jul 23, 2019 at 05:25:27PM +0800, Chao Yu wrote: > Move _require_prjquota() to front of _qmount() since we do the > check on device directly instead of mountpoint, it can avoid > potential failure if filesystem utils needs exclusive open on > device. > > Signed-off-by: Chao Yu We've done similar changes before 23f60ef304d6 ("generic/38[3-6]: require project quota to be enabled on SCRATCH_DEV") but later it was reverted by f722c48d4cd5 ("Revert "generic/38[3-6]: require project quota to be enabled on SCRATCH_DEV"") Because we use quotactl(2) to check if prjquota is enabled on the given device (src/feature -P $dev in _require_prjquota), and quotactl(2) requires the given device is a mounted device. Thanks, Eryu > --- > tests/generic/383 | 2 +- > tests/generic/384 | 2 +- > tests/generic/385 | 2 +- > tests/generic/386 | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/generic/383 b/tests/generic/383 > index 2c8c5923..cf5ac255 100755 > --- a/tests/generic/383 > +++ b/tests/generic/383 > @@ -39,6 +39,7 @@ _require_xfs_quota_foreign > > _scratch_mkfs >/dev/null 2>&1 > _scratch_enable_pquota > +_require_prjquota $SCRATCH_DEV > > do_project_test() > { > @@ -76,7 +77,6 @@ EOF > # Test project > _qmount_option "usrquota,prjquota" > _qmount > -_require_prjquota $SCRATCH_DEV > do_project_test > > # success, all done > diff --git a/tests/generic/384 b/tests/generic/384 > index b7c940d7..2c0cd00b 100755 > --- a/tests/generic/384 > +++ b/tests/generic/384 > @@ -57,10 +57,10 @@ chmod a+rwx $seqres.full # arbitrary users will write here > _require_scratch > _scratch_mkfs >/dev/null 2>&1 > _scratch_enable_pquota > +_require_prjquota $SCRATCH_DEV > > _qmount_option "prjquota" > _qmount > -_require_prjquota $SCRATCH_DEV > > report_quota() > { > diff --git a/tests/generic/385 b/tests/generic/385 > index 937131a9..56ce6eb0 100755 > --- a/tests/generic/385 > +++ b/tests/generic/385 > @@ -56,9 +56,9 @@ quota_cmd="$XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid" > > _scratch_mkfs >/dev/null 2>&1 > _scratch_enable_pquota > +_require_prjquota $SCRATCH_DEV > _qmount_option "prjquota" > _qmount > -_require_prjquota $SCRATCH_DEV > > # > # Create the project root > diff --git a/tests/generic/386 b/tests/generic/386 > index 462c5869..e4f7d23b 100755 > --- a/tests/generic/386 > +++ b/tests/generic/386 > @@ -112,10 +112,10 @@ echo $proj_num:$proj_dir > "$my_projects" > > _scratch_mkfs >> "$seqres.full" 2>&1 > _scratch_enable_pquota > +_require_prjquota $SCRATCH_DEV > > _qmount_option "prjquota" > _qmount > -_require_prjquota $SCRATCH_DEV > > mkdir -p "${proj_dir}" > > -- > 2.18.0.rc1 > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel