From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E38C3A5A0 for ; Tue, 20 Aug 2019 01:00:10 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7FB022CF5 for ; Tue, 20 Aug 2019 01:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="eiDgQhj7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="lUY+HaUM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kUAUu8VZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7FB022CF5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hzsVN-0005NR-5a; Tue, 20 Aug 2019 01:00:09 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hzsVM-0005NF-G2 for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Aug 2019 01:00:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gwgc3ZJr4NkmKAJ26RhpTUQ2I0vGE7pRfPFOFidEa7w=; b=eiDgQhj7sSjFO3Y5007hX0zYrv REkS2H6OoPvvyBYTyQzRcgm3/NEO6C26M2xh4b68qpy2qvFz4FIsEdgefpyA4WC41vAZ/K/5cxQR7 FpxgOVkTiokwW4Z/QtD6jw4Iev6kCtQrKFro3fcIyw0pXBGKvYxv/cjppvrwq0atdnyY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gwgc3ZJr4NkmKAJ26RhpTUQ2I0vGE7pRfPFOFidEa7w=; b=lUY+HaUM/Ek2z1vpvXUhXCgRCh riBwrA/7HA0Rp5MMjXeHZIHePRKMYM8vepFIm19S4RW39DB5V+a0wpIt9gX2LZZn+kRPEzsR9jsHM nEe79SrdThkGoI6n6mq8O14XplY8CeaEUtUFg/YRxveYpErYjXLmygsPubRBILLA0RH0=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hzsVL-009FuT-AS for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Aug 2019 01:00:08 +0000 Received: from localhost (unknown [104.132.0.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B2F322CE8; Tue, 20 Aug 2019 01:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566262801; bh=3k09FSAiN1EmDJYOwHzqIY0z6rdM/xIPz2fJfXY0Jd0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kUAUu8VZBvG8TphqNQTLtnrtRoyjj9IAiv0JICGK8sVXH8kfovJr0OYIWhDXlU/kO Ra2ZbTLGqBu6qfYh0SaXYzLXT6+WwcVwzI6wccUMKh3be1h/qrXcDI9mEcSpGoVyYE PZpZcRfLUwHiS2krWglhoAYamsiI9UEtADMq1Has= Date: Mon, 19 Aug 2019 18:00:00 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20190820010000.GA45681@jaegeuk-macbookpro.roam.corp.google.com> References: <20190816030334.81035-1-yuchao0@huawei.com> <3349ceea-85ac-173a-81a4-1188ce3804ca@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3349ceea-85ac-173a-81a4-1188ce3804ca@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) X-Headers-End: 1hzsVL-009FuT-AS Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 08/19, Chao Yu wrote: > On 2019/8/16 11:03, Chao Yu wrote: > > There is one case can cause data corruption. > > > > - write 4k to fileA > > - fsync fileA, 4k data is writebacked to lbaA > > - write 4k to fileA > > - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet > > - write 4k to fileB > > - kworker flush 4k to lbaA due to SSR > > - SPOR -> dnode with lbaA will be recovered, however lbaA contains fileB's > > data > > > > One solution is tracking all fsynced file's block history, and disallow > > SSR overwrite on newly invalidated block on that file. > > > > However, during recovery, no matter the dnode is flushed or fsynced, all > > previous dnodes until last fsynced one in node chain can be recovered, > > that means we need to record all block change in flushed dnode, which > > will cause heavy cost, so let's just use simple fix by forbidding SSR > > overwrite directly. > > > > Jaegeuk, > > Please help to add below missed tag to keep this patch being merged in stable > kernel. > > Fixes: 5b6c6be2d878 ("f2fs: use SSR for warm node as well") Done. > > Thanks, > > > Signed-off-by: Chao Yu > > --- > > fs/f2fs/segment.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > > index 9d9d9a050d59..69b3b553ee6b 100644 > > --- a/fs/f2fs/segment.c > > +++ b/fs/f2fs/segment.c > > @@ -2205,9 +2205,11 @@ static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del) > > if (!f2fs_test_and_set_bit(offset, se->discard_map)) > > sbi->discard_blks--; > > > > - /* don't overwrite by SSR to keep node chain */ > > - if (IS_NODESEG(se->type) && > > - !is_sbi_flag_set(sbi, SBI_CP_DISABLED)) { > > + /* > > + * SSR should never reuse block which is checkpointed > > + * or newly invalidated. > > + */ > > + if (!is_sbi_flag_set(sbi, SBI_CP_DISABLED)) { > > if (!f2fs_test_and_set_bit(offset, se->ckpt_valid_map)) > > se->ckpt_valid_blocks++; > > } > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel