From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE202C3A5A8 for ; Sun, 1 Sep 2019 07:18:11 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE6E122CF7 for ; Sun, 1 Sep 2019 07:18:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="I/Hii809"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="dP9higyx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="T27OuVHr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE6E122CF7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i4K7n-0004KO-55; Sun, 01 Sep 2019 07:18:11 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i4K7l-0004KA-QB for linux-f2fs-devel@lists.sourceforge.net; Sun, 01 Sep 2019 07:18:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qo0JPDahUDhz2sL8eW6q6OaXEV14QOHbDYWTVA0Lq5Q=; b=I/Hii809SyfKVP2UMFK2ZWKT9B E6sHUzWhB4yQQK4DKo/xWYKaqxOriYwNFoCV6eqzoc217rIi3Ig/jITtXDdTvhz1XUthPhVQIY8Pw vaaTnbS5N6tBDA2XF3AfJqlSBeoEmGfWPjNRbhqoJdj/ut0uSDvBcqRGJTs/u/0BOCg4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qo0JPDahUDhz2sL8eW6q6OaXEV14QOHbDYWTVA0Lq5Q=; b=dP9higyxOGmAbywSZC7bnuJZi6 A8Sb8/Rwg8025Rw3MFp4yhAWX3gOQzEqNkvL2f38fbOQvMboEhwH931t6ygo7fgHBjJnT0qetRNwN k6MCs9BFybLRJCU7mrPk06cr9YINFaQBUaO5Cg+T173WVKQGHD8+et7xWHXX/lwh0G9U=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1i4K7f-00BLHe-LL for linux-f2fs-devel@lists.sourceforge.net; Sun, 01 Sep 2019 07:18:09 +0000 Received: from localhost (unknown [104.132.0.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE4CE22CF7; Sun, 1 Sep 2019 07:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567322278; bh=csVVin+Olpb/qDxAyD+cBrDfz5AYW4dnPEW/8nHkCXU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T27OuVHr9dwrxAnstXVsyaik9OZpoR4Vpdc8V26AcSOcVEDLxYXSQRUKEPVF9Efr7 2gsuumL5aEwqeupMejKbNDz7AEBBhcj2ObGMBGxIkvfPKa0jNR6MkcyhZhW89QLl2E pIw0wT+ll3v0yX3/Ff2kspPG431Kosc9m6EveRKY= Date: Sun, 1 Sep 2019 00:17:57 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20190901071757.GA49907@jaegeuk-macbookpro.roam.corp.google.com> References: <20190219081529.5106-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) X-Headers-End: 1i4K7f-00BLHe-LL Subject: Re: [f2fs-dev] [PATCH v4] f2fs: add bio cache for IPU X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 08/31, Chao Yu wrote: > On 2019/2/19 16:15, Chao Yu wrote: > > @@ -1976,10 +2035,13 @@ static int __write_data_page(struct page *page, bool *submitted, > > } > > > > unlock_page(page); > > - if (!S_ISDIR(inode->i_mode) && !IS_NOQUOTA(inode)) > > + if (!S_ISDIR(inode->i_mode) && !IS_NOQUOTA(inode)) { > > + f2fs_submit_ipu_bio(sbi, bio, page); > > f2fs_balance_fs(sbi, need_balance_fs); > > + } > > Above bio submission was added to avoid below deadlock: > > - __write_data_page > - f2fs_do_write_data_page > - set_page_writeback ---- set writeback flag > - f2fs_inplace_write_data > - f2fs_balance_fs > - f2fs_gc > - do_garbage_collect > - gc_data_segment > - move_data_page > - f2fs_wait_on_page_writeback > - wait_on_page_writeback --- wait writeback > > However, it breaks the merge of IPU IOs, to solve this issue, it looks we need > to add global bio cache for such IPU merge case, then later > f2fs_wait_on_page_writeback can check whether writebacked page is cached or not, > and do the submission if necessary. > > Jaegeuk, any thoughts? How about calling f2fs_submit_ipu_bio() when we need to do GC in the same context? > > Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel