From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 596B3C4740C for ; Mon, 9 Sep 2019 12:04:55 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29F492067B; Mon, 9 Sep 2019 12:04:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="bknNt4Ve"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="FgCwL+RM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hg+y8W+v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29F492067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i7IPe-0002gZ-NV; Mon, 09 Sep 2019 12:04:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i7IPe-0002gT-3z for linux-f2fs-devel@lists.sourceforge.net; Mon, 09 Sep 2019 12:04:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MR3aaNIpDHFxzPvYYJOupc9Xx4OY/goS2zSm9lBMuQs=; b=bknNt4VeKQpyBshF2Fzkbq6ruR 2sggNyC97EAj2NLb1kfkTH5gclc01+5fid+Gw7zuJsiH/LPdmZoKh0uFwDU+8enqyfgD/DKQ4/2E6 dp4QnqKvMKeZbqgSDBRL2Tk1BR3nrSq7fEGobJCBggJAeQmmot69dSrzEaPZu//NSZrw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MR3aaNIpDHFxzPvYYJOupc9Xx4OY/goS2zSm9lBMuQs=; b=FgCwL+RMOYbuv4WPpu6Wr0+KdK DZZ6z7AgOwx99hsXbTxmAVs2QESk/OEtyakqF0VBHLohfTCHPX380WuQV82woZ107IBjQbswim5UI AHOIN4Lik+iv2IIMef5CBC75/EqPWSPV18i+92q2tjI8kJQrtz4d+Iz05az4LU7UNSEw=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1i7IPc-00F3Rw-8P for linux-f2fs-devel@lists.sourceforge.net; Mon, 09 Sep 2019 12:04:54 +0000 Received: from localhost (unknown [148.69.85.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28BD82067B; Mon, 9 Sep 2019 12:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568030686; bh=9b/8IY4QOe0LwdrOWJ2ftTvFx8mgPq5bP/abAgWH+0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hg+y8W+vKwgkCTchcgPlYP+HxphpgwrPcPZ/0M+tRDuKTjIpACy6zxOY4caDcM9JN yRRLQTNTL5dPIzmtwh2Letb8gNbTQ3XUHLI2XQrOSiiKvpedAD1FZ2KE0e3Qxalosk AI3g57p16XzVXxvOIczb2SrDXjwqRbG7rpueyzKA= Date: Mon, 9 Sep 2019 13:04:43 +0100 From: Jaegeuk Kim To: Chao Yu Message-ID: <20190909120443.GA31108@jaegeuk-macbookpro.roam.corp.google.com> References: <20190909012532.20454-1-jaegeuk@kernel.org> <69933b7f-48cc-47f9-ba6f-b5ca8f733cba@huawei.com> <20190909080654.GD21625@jaegeuk-macbookpro.roam.corp.google.com> <97237da2-897a-8420-94de-812e94aa751f@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <97237da2-897a-8420-94de-812e94aa751f@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) X-Headers-End: 1i7IPc-00F3Rw-8P Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: do not select same victim right again X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 09/09, Chao Yu wrote: > On 2019/9/9 16:06, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 9:25, Jaegeuk Kim wrote: > >>> GC must avoid select the same victim again. > >> > >> Blocks in previous victim will occupy addition free segment, I doubt after this > >> change, FGGC may encounter out-of-free space issue more frequently. > > > > Hmm, actually this change seems wrong by sec_usage_check(). > > We may be able to avoid this only in the suspicious loop? > > > > --- > > fs/f2fs/gc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > > index e88f98ddf396..5877bd729689 100644 > > --- a/fs/f2fs/gc.c > > +++ b/fs/f2fs/gc.c > > @@ -1326,7 +1326,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, > > round++; > > } > > > > - if (gc_type == FG_GC) > > + if (gc_type == FG_GC && seg_freed) > > That's original solution Sahitya provided to avoid infinite loop of GC, but I > suggest to find the root cause first, then we added .invalid_segmap for that > purpose. I've checked the Sahitya's patch. So, it seems the problem can happen due to is_alive or atomic_file. > > Thanks, > > > sbi->cur_victim_sec = NULL_SEGNO; > > > > if (sync) > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel