From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12BF0C432C2 for ; Wed, 25 Sep 2019 13:48:37 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0D1621D81; Wed, 25 Sep 2019 13:48:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="TYu7VFT7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="QD9DiMrj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0D1621D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iD7em-0006oi-6b; Wed, 25 Sep 2019 13:48:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iD7ek-0006ob-JO for linux-f2fs-devel@lists.sourceforge.net; Wed, 25 Sep 2019 13:48:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gBFI+SYRfB4bIEWDn/6MBy1SllCRtqBZq1IHY8wh+cM=; b=TYu7VFT7QLAQquhOdm5OZ/LU47 U/j8Y44MhqXQB8Ug3tJpg8i/0+bN5F3fKr9JQVibYkhM/D8MmBJJq41RI5ydwbWRiw6cb485b3tH9 Th1IG+8zPPS2e0HQt8zynwp4qSdxxTg47EgOScevLIg5y0deKyS23Hm9fVofMm9lY5FI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:CC:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gBFI+SYRfB4bIEWDn/6MBy1SllCRtqBZq1IHY8wh+cM=; b=QD9DiMrjhmG1i22NYdZX0NtizZ CKtsBZR9f5phzyxu1EANQn33qxP7pjZq6OkisDtJiq4pz78c+e5LHY/xk+DGgF2rr2XnXL1nYI4NU /7huVQZs6O1uTZhSiNOhmvJ6UbUXOELfc5Nvv3rEWcGacBEXE6AEzs+CBnSWp4OBN0tM=; Received: from szxga02-in.huawei.com ([45.249.212.188] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iD7ei-008S8g-93 for linux-f2fs-devel@lists.sourceforge.net; Wed, 25 Sep 2019 13:48:34 +0000 Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id 953ADF9E6B6000EE6D6D; Wed, 25 Sep 2019 21:48:22 +0800 (CST) Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by DGGEMM406-HUB.china.huawei.com (10.3.20.214) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 21:48:22 +0800 Received: from architecture4 (10.140.130.215) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 25 Sep 2019 21:48:21 +0800 Date: Wed, 25 Sep 2019 21:47:06 +0800 From: Gao Xiang To: Chao Yu Message-ID: <20190925134706.GA157912@architecture4> References: <20190925093050.118921-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190925093050.118921-1-yuchao0@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.140.130.215] X-ClientProxiedBy: dggeme708-chm.china.huawei.com (10.1.199.104) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected X-Headers-End: 1iD7ei-008S8g-93 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix comment of f2fs_evict_inode X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi Chao, On Wed, Sep 25, 2019 at 05:30:50PM +0800, Chao Yu wrote: > evict() should be called once i_count is zero, rather than i_nlinke > is zero. > > Reported-by: Gao Xiang > Signed-off-by: Chao Yu > --- > fs/f2fs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index db4fec30c30d..8262f4a483d3 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -632,7 +632,7 @@ int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc) > } > > /* > - * Called at the last iput() if i_nlink is zero > + * Called at the last iput() if i_count is zero Yeah, I'd suggest taking some time to look at other inconsistent comments, it makes other folks confused and ask me with such-"strong" reason... Thanks, Gao Xiang > */ > void f2fs_evict_inode(struct inode *inode) > { > -- > 2.18.0.rc1 > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel