From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Gwendal Grignou <gwendal@chromium.org>,
apronin@chromium.org, Ryo Hashimoto <hashimoto@chromium.org>,
sukhomlinov@google.com, Douglas Anderson <dianders@chromium.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, groeck@chromium.org,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] Revert "ext4 crypto: fix to check feature status before get policy"
Date: Thu, 31 Oct 2019 12:45:50 -0400 [thread overview]
Message-ID: <20191031164550.GF16197@mit.edu> (raw)
In-Reply-To: <20191030215138.224671-1-ebiggers@kernel.org>
On Wed, Oct 30, 2019 at 02:51:38PM -0700, Eric Biggers wrote:
> From: Douglas Anderson <dianders@chromium.org>
>
> This reverts commit 0642ea2409f3 ("ext4 crypto: fix to check feature
> status before get policy").
>
> The commit made a clear and documented ABI change that is not backward
> compatible. There exists userspace code [1][2] that relied on the old
> behavior and is now broken.
>
> While we could entertain the idea of updating the userspace code to
> handle the ABI change, it's my understanding that in general ABI
> changes that break userspace are frowned upon (to put it nicely).
The rule is that if someone complains, we have to revert. Douglas's
email counts as a complaint, so we should revert. That being said, if
ChromeOS (userspace) changes to using /sys/fs/ext4/features/encryption
to determine whether or not the kernel supports encryption, then we
can in the future change the error code to make things consistent with
f2fs.
This looks good, I'll pull it into ext4 git tree.
- Ted
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2019-10-31 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 21:51 [f2fs-dev] [PATCH v2] Revert "ext4 crypto: fix to check feature status before get policy" Eric Biggers
2019-10-31 16:45 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031164550.GF16197@mit.edu \
--to=tytso@mit.edu \
--cc=apronin@chromium.org \
--cc=dianders@chromium.org \
--cc=ebiggers@kernel.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=hashimoto@chromium.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=sukhomlinov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).