From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D32C432C0 for ; Thu, 28 Nov 2019 15:45:48 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 617F6217BA for ; Thu, 28 Nov 2019 15:45:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="WD0gBMn9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="fw/srnCp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lYn5QAbb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 617F6217BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iaLzH-0000Ni-L4; Thu, 28 Nov 2019 15:45:47 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iaLzG-0000N4-1h for linux-f2fs-devel@lists.sourceforge.net; Thu, 28 Nov 2019 15:45:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1Ua9kzhqWdT/XmuB+JkZPQ/zR7CbGzhbDxmS9/PUHRg=; b=WD0gBMn9ZRN8RDIA6sqQazE7+e Iad5pN/PuXUcD33y4bB7vqTiFBxOQnj1o5+sxibqS1FoNS/WrYkhW45+mfXJ8r//hf5ExclaAAovx y54MemuknkMzQgpZmJ9BeXcjrodZ0LT+52EDKaJ4xT9deZ8pmZmQBb+kpUjLJpa/D3qQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1Ua9kzhqWdT/XmuB+JkZPQ/zR7CbGzhbDxmS9/PUHRg=; b=fw/srnCpoTlNCRq9AY7BTV1E/0 Jz6Qxy1EC6ORrrHldCbn3bK70Ao7TLt8EKL8qqu/Rj+y4/WKrqdyux2ZqXlLxDtZuPxB7yNBW18VR qj6pi+TCdzOUn3qPHzxrHhXVmVKQLjiSvvRItNbYiPDto+eu0fyoPHTd3fyxx7vMmugI=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iaLzE-00GH5p-4P for linux-f2fs-devel@lists.sourceforge.net; Thu, 28 Nov 2019 15:45:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1Ua9kzhqWdT/XmuB+JkZPQ/zR7CbGzhbDxmS9/PUHRg=; b=lYn5QAbbuOgCVzO0wK72zGcGg mQTVtUtKdl4KYiJHp4I5I3FXK/6FWZhfra4tUuTFV7QC78oDUm8NKzHIrgasl+8sbPlrCdG0T67u3 kgAQ57kaMp3R3h1Z+mwXZn4SMTDknO5FcjPcWJhT6kEGYu4yyJ+8h7G98UfdWJKrqUQljjAF2xpQv RhfjlbJLk4dNosXzbNYjYOLiCEP2PZWfBnLjpu5EMP/cgJOBC3HTYk0zTcErIw08z7ffMbdnD/r09 tSSlveUJqScNNE8ME81M1Rd4A954YOsGafxeRRIk7ktZ64V53SmN+UKMgMG5kfHDds764Ihn7lkwx SsNl980Fw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaLym-0005vg-OI; Thu, 28 Nov 2019 15:45:16 +0000 Date: Thu, 28 Nov 2019 07:45:16 -0800 From: Christoph Hellwig To: "Darrick J. Wong" Message-ID: <20191128154516.GA17166@infradead.org> References: <20191127151811.9229-1-agruenba@redhat.com> <20191127154954.GT6219@magnolia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191127154954.GT6219@magnolia> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1iaLzE-00GH5p-4P Subject: Re: [f2fs-dev] [PATCH] fs: Fix page_mkwrite off-by-one errors X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Theodore Ts'o , Andreas Gruenbacher , Sage Weil , Artem Bityutskiy , Richard Weinberger , Jeff Layton , linux-kernel@vger.kernel.org, Adrian Hunter , Christoph Hellwig , Andreas Dilger , Alexander Viro , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , Ilya Dryomov , linux-ext4@vger.kernel.org, Linus Torvalds , ceph-devel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Nov 27, 2019 at 07:49:54AM -0800, Darrick J. Wong wrote: > On Wed, Nov 27, 2019 at 04:18:11PM +0100, Andreas Gruenbacher wrote: > > Fix a check in block_page_mkwrite meant to determine whether an offset > > is within the inode size. This error has spread to several filesystems > > and to iomap_page_mkwrite, so fix those instances as well. > > Seeing how this has gotten screwed up at least six times in the kernel, > maybe we need a static inline helper to do this for us? Yes. I think we really want a little helper that checks the mapping and the offset. That also gives us the opportunity to document the semantics. > > > Signed-off-by: Andreas Gruenbacher > > The iomap part looks ok, > Reviewed-by: Darrick J. Wong > > (I might just extract the iomap part and put it in the iomap tree if > someone doesn't merge this one before I get to it...) I think we should just pull in the helper and conversions through some tree after all iomap bits are merged. It might as well be the iomap tree as that seems to the place for file system read/write infrastructure these days. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel