From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4761C1975A for ; Wed, 25 Mar 2020 15:58:23 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CC612073E for ; Wed, 25 Mar 2020 15:58:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="GdXIfwnl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="BB6Onx6x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="V+62TTJE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CC612073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jH8Q9-00072L-UB; Wed, 25 Mar 2020 15:58:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jH8Q8-00072D-Ri for linux-f2fs-devel@lists.sourceforge.net; Wed, 25 Mar 2020 15:58:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bgo+Wra9hmQz7pHxUHMG3wIw7vOhUiz/LWeqeYLGvqc=; b=GdXIfwnl8FBIa1dayYRHrQwDBh if6tsbdvd3dySe4g1/1vj/rbFBP1ZtEMEE73ZHO0imwpMOCSaIUvLPaHSJaaX6ALHj0DeOjcry4MN doejxomb7yUfjS0VP4fP8SEhYkXuFLP/Q1s6FAFnXYAn0RWznjZLlBjgHFXIf1awe6gM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Bgo+Wra9hmQz7pHxUHMG3wIw7vOhUiz/LWeqeYLGvqc=; b=BB6Onx6xLHY9ZznVy1YRK7HE9I ukd60yz7/d1SydWpm5v0encgytx9pfdHjA/5Z+4NnfOlJTDnMPB9K2nW7rMb8Zyq+QKICAYJjK2uZ Liqvn8MjLAxehlBhNTFve5jhkj/VGm6L+6/nDWVEhcXQkDWCAI79A+tLlfnoeyoHsMx0=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jH8Q0-0037CE-Ov for linux-f2fs-devel@lists.sourceforge.net; Wed, 25 Mar 2020 15:58:20 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F0202073E; Wed, 25 Mar 2020 15:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585151887; bh=yuKPw9zHwSe4jPNUbVFEbNmFqcIFFFDut0JgQS3oKmM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V+62TTJEnnakM8FVs3+TfAH+O1aXF1HvMmeMiJl/SqXlqkbVYSu62irvYLvhOUN74 9ev7B2Xcdw4Owa+w+k2grU+BoD5RMypGl7iUXrhiOEp6YankzEDZfP3nlJ56BPJpPl /sEtWZSo85MnjUDhIvS/bwuNA1k8K0yE3Prk7BcM= Date: Wed, 25 Mar 2020 08:58:06 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20200325155806.GC65658@google.com> References: <20200325092754.63411-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200325092754.63411-1-yuchao0@huawei.com> X-Headers-End: 1jH8Q0-0037CE-Ov Subject: Re: [f2fs-dev] [PATCH RFC] f2fs: don't inline compressed inode X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 03/25, Chao Yu wrote: > f2fs_may_inline_data() only check compressed flag on current inode > rather than on parent inode, however at this time compressed flag > has not been inherited yet. When write() or other allocation happens, it'll be reset. > > Signed-off-by: Chao Yu > --- > > Jaegeuk, > > I'm not sure about this, whether inline_data flag can be compatible with > compress flag, thoughts? > > fs/f2fs/namei.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c > index f54119da2217..3807d1b4c4bc 100644 > --- a/fs/f2fs/namei.c > +++ b/fs/f2fs/namei.c > @@ -86,7 +86,8 @@ static struct inode *f2fs_new_inode(struct inode *dir, umode_t mode) > if (test_opt(sbi, INLINE_XATTR)) > set_inode_flag(inode, FI_INLINE_XATTR); > > - if (test_opt(sbi, INLINE_DATA) && f2fs_may_inline_data(inode)) > + if (test_opt(sbi, INLINE_DATA) && f2fs_may_inline_data(inode) && > + !f2fs_compressed_file(dir)) > set_inode_flag(inode, FI_INLINE_DATA); > if (f2fs_may_inline_dentry(inode)) > set_inode_flag(inode, FI_INLINE_DENTRY); > -- > 2.18.0.rc1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel