From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: prevent meta updates while checkpoint is in progress
Date: Fri, 17 Apr 2020 09:15:16 -0700 [thread overview]
Message-ID: <20200417161516.GA17901@google.com> (raw)
In-Reply-To: <e1b763bf-7f72-01eb-a368-9b70e0f46f55@huawei.com>
Hi Sahitya,
Could you please test this patch fully? I didn't test at all.
Thanks,
On 04/17, Chao Yu wrote:
> On 2020/4/17 5:40, Jaegeuk Kim wrote:
> > On 04/14, Jaegeuk Kim wrote:
> >> On 04/13, Jaegeuk Kim wrote:
> >>> On 04/03, Jaegeuk Kim wrote:
> >>>> On 04/03, Jaegeuk Kim wrote:
> >>>>> On 04/01, Sahitya Tummala wrote:
> >>>>>> Hi Jaegeuk,
> >>>>>>
> >>>>>> Got it.
> >>>>>> The diff below looks good to me.
> >>>>>> Would you like me to test it and put a patch for this?
> >>>>>
> >>>>> Sahitya, Chao,
> >>>>>
> >>>>> Could you please take a look at this patch and test intensively?
> >>>>>
> >>>>> Thanks,
> >
> > v5:
> > - add signal handler
> >
> > Sahitya raised an issue:
> > - prevent meta updates while checkpoint is in progress
> >
> > allocate_segment_for_resize() can cause metapage updates if
> > it requires to change the current node/data segments for resizing.
> > Stop these meta updates when there is a checkpoint already
> > in progress to prevent inconsistent CP data.
> >
> > Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-04-17 16:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 10:36 [f2fs-dev] [PATCH] f2fs: prevent meta updates while checkpoint is in progress Sahitya Tummala
2020-03-27 19:24 ` Jaegeuk Kim
2020-03-28 8:38 ` Chao Yu
2020-03-30 8:40 ` Sahitya Tummala
2020-03-30 18:34 ` Jaegeuk Kim
2020-03-31 0:58 ` Chao Yu
2020-03-31 3:54 ` Jaegeuk Kim
2020-03-31 9:06 ` Sahitya Tummala
2020-03-31 18:43 ` Jaegeuk Kim
2020-04-01 2:54 ` Chao Yu
2020-04-03 16:20 ` Jaegeuk Kim
2020-04-01 5:08 ` Sahitya Tummala
2020-04-03 17:17 ` Jaegeuk Kim
2020-04-03 17:27 ` Jaegeuk Kim
2020-04-07 2:34 ` Chao Yu
2020-04-07 2:58 ` Jaegeuk Kim
2020-04-07 3:21 ` Chao Yu
2020-04-09 2:25 ` Jaegeuk Kim
2020-04-13 17:42 ` Jaegeuk Kim
2020-04-14 9:58 ` Sahitya Tummala
2020-04-14 11:44 ` Chao Yu
2020-04-14 13:44 ` Jaegeuk Kim
2020-04-16 7:04 ` Chao Yu
2020-04-16 21:40 ` Jaegeuk Kim
2020-04-17 7:26 ` Chao Yu
2020-04-17 16:15 ` Jaegeuk Kim [this message]
2020-04-20 11:37 ` Sahitya Tummala
2020-04-20 15:52 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417161516.GA17901@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).