From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 450DFC2BA19 for ; Tue, 21 Apr 2020 03:25:30 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D08E206F9 for ; Tue, 21 Apr 2020 03:25:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="dJtcYWwN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="lHCYbnIH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JG7FSWTd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D08E206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jQjXM-0000op-9C; Tue, 21 Apr 2020 03:25:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jQjXK-0000oW-CI for linux-f2fs-devel@lists.sourceforge.net; Tue, 21 Apr 2020 03:25:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yMiQgSp6+44yHi8Y/SiNH79yEV2BxaTZglsheeQ2n48=; b=dJtcYWwN5RP2/cc7PZ7TnhqnPs VhiQSWF/EpNBXYQm1EPNKM3dZOL1j9rkgXhePqWCgs8+oeVEMrbyyP+ybrCUhqZ0uGpJfIlgFS/x/ pjk/xaTUxHg3RD+OV4RUoaMSN2AG1oFEbKocFPCppVARbMSZjNyFYQlQ/IJZX8hlm1nc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yMiQgSp6+44yHi8Y/SiNH79yEV2BxaTZglsheeQ2n48=; b=lHCYbnIHWwb6/WdsHj/OVgueL5 MUpr0M2F/YNDx3i1OgQqUOK5jFt69V4mMxsm9JQaCRGcWNiPrfUl1KeHLUTtjGkKpiObimdgtGAM7 aEcHik3v7YFnda7nmhZBKGCxiixoerp+GqxdYvWoehRfwWOMkmZKpFJ415TbehHTHCcg=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jQjXI-0050L1-FO for linux-f2fs-devel@lists.sourceforge.net; Tue, 21 Apr 2020 03:25:26 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C310206F9; Tue, 21 Apr 2020 03:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587439513; bh=H29oCtqsrJtGWyg/QmRKF2AXzQxEwBYJaGQqfrdaBIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JG7FSWTdN2QwjRKOyL04yifSxZUp8D6NrGwqKaBut9eS5w882u7MYS5c1iXvZaWzV p6tdkBdfSdH31LdypXsi3BPb4bgmWo4E830nbs5CKfm6qn8/WOZAKBZhpkwSk3yFB7 bmkquRPoaiAVVlV68lzal/m9OjYpn2eYa4YVTveI= Date: Mon, 20 Apr 2020 20:25:13 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20200421032513.GA134303@google.com> References: <20200415021313.95538-1-yuchao0@huawei.com> <634e3958-ee48-90b1-f32f-60e2bc4ca88e@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <634e3958-ee48-90b1-f32f-60e2bc4ca88e@huawei.com> X-Headers-End: 1jQjXI-0050L1-FO Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix to avoid page count leak X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 04/21, Chao Yu wrote: > Hi Jaegeuk, > > Let's drop this patch, I encounter bad page state (nonzero refcount) reported > by vm w/ this patch. Ok. > > On 2020/4/15 10:13, Chao Yu wrote: > > In f2fs_read_data_pages(), once we add page into radix tree, we need to > > release reference count of that page, however when f2fs_read_multi_pages() > > fails, we didn't handle that case correctly, fix it. > > > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > > Signed-off-by: Chao Yu _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel