From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA10C83004 for ; Tue, 28 Apr 2020 05:21:46 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB48B206A1; Tue, 28 Apr 2020 05:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="ApYpNo44"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="NwSuPSCc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="kz5m517c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB48B206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jTIgj-0003MV-FK; Tue, 28 Apr 2020 05:21:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jTIgi-0003MK-Cq for linux-f2fs-devel@lists.sourceforge.net; Tue, 28 Apr 2020 05:21:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=btOt+GJLXunt0yTMMtppqrdFkNuz4JVhPhDALsvkRkA=; b=ApYpNo44z+QmRlnbtdV/ZMnFX+ ZZiSj+VZahfdAJ/596hjiLE6f0jSRNtsUvCcZYIH5Y4SARTvODUDEMKWxoTYHMdOjW4X8CXWMRWSX WLShVQmvd9eME9SlIrH+3CN5X9XfDKXaJeZXYP6wwS6/UjgCFNdnE0GZPunmX7CvhYwk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=btOt+GJLXunt0yTMMtppqrdFkNuz4JVhPhDALsvkRkA=; b=NwSuPSCcC1+gWIwB0kvnqlckkD /xBBve+/Sq21+kGegn8cX0Tacc/7dE3wjOjfqvoGLikHBhfpGRUFD696RidkeOZ4raciRTQOqoNGs /SJLFRqglGnK7XTKjUtRzrvM1uxyUCp+zilhbOU6zip+vGwRxKVd+jIO04a6WpvEqWgA=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jTIgh-00HB1v-5o for linux-f2fs-devel@lists.sourceforge.net; Tue, 28 Apr 2020 05:21:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=btOt+GJLXunt0yTMMtppqrdFkNuz4JVhPhDALsvkRkA=; b=kz5m517ctvWWh0t+4t+NNx9Rkl oSOdlk3JhkkXMDaa1VXuyAuOlgzyjrq+DfEknFCzMsNsNY5Y11InfWh1vPzPfatUmjLvaIt+vuyJ7 UjVnIOCXBM+KbNMLyHebA828UmsFNiFJ4M+556kOcvZpoViWvsHil2m5CkXcO5J5Qpa+N4z5ORNKF SJtdsfnm2D+NUex27zd3t0dsPhZMOzLWY4+NYcDsQTzWVp9eAQxz4w6HYzBAgdHV2epdrEUQgn20a jtZtq0M/x7iQLMizoT6OXUEY/2Vt6UyCtDMCx1tEOo/VMDd7gBUh36aJT/v98gAZEmK75nZJQvdue Ivt3QYjA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTIgb-0007Fy-Dl; Tue, 28 Apr 2020 05:21:37 +0000 Date: Mon, 27 Apr 2020 22:21:37 -0700 From: Christoph Hellwig To: Satya Tangirala Message-ID: <20200428052137.GA18572@infradead.org> References: <20200408035654.247908-1-satyat@google.com> <20200408035654.247908-4-satyat@google.com> <20200422093502.GB12290@infradead.org> <20200428025400.GB52406@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428025400.GB52406@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1jTIgh-00HB1v-5o Subject: Re: [f2fs-dev] [PATCH v10 03/12] block: Inline encryption support for blk-mq X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, Kim Boojin , Kuohong Wang , Barani Muthukumaran , linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Apr 28, 2020 at 02:54:00AM +0000, Satya Tangirala wrote: > It's modified by additions in the next patch in the series and I > thought I should introduce the function with the final type from the > get go - is that alright? It is probably ok, let me review the next patch in more detail. > > > __blk_queue_split(q, &bio, &nr_segs); > > > @@ -2011,6 +2015,15 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio) > > > > > > blk_mq_bio_to_request(rq, bio, nr_segs); > > > > > > + ret = blk_crypto_init_request(rq); > > > + if (ret != BLK_STS_OK) { > > > + bio->bi_status = ret; > > > + bio_endio(bio); > > > + blk_mq_free_request(rq); > > > + return BLK_QC_T_NONE; > > > + } > > > > Didn't Eric have a comment last round that we shoul dtry this before > > attaching the bio to simplify error handling? > > > In the previous round, I believe Eric commented that I should call > blk_crypto_init_request after bio_to_request so that we can do away > with some of the arguments to blk_crypto_init_request and also a > boilerplate function used only while calling blk_crypto_init_request. > I realize you wrote "And we can fail just the request on an error, so > yes this doesn't seem too bad." in response to this particular > comment of Eric's, and it seems I might not actually have understood > what that meant - did you have something in mind different from what I'm > doing here? No, this looks ok, sorry for the noise. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel