linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Linux F2FS Dev Mailing List <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] Discard issue
Date: Mon, 25 May 2020 19:26:46 -0700	[thread overview]
Message-ID: <20200526022646.GA226136@google.com> (raw)
In-Reply-To: <9a09da49-9b3d-68c3-f47f-40bb7e4309b8@huawei.com>

On 05/26, Chao Yu wrote:
> Hi Jaegeuk,
> 
> On 2020/5/26 9:59, Jaegeuk Kim wrote:
> > Hi Chao,
> > 
> > I'm hitting segment.c:1065 when running longer fsstress (1000s) with error
> 
> (1000s) do you mean time in single round or total time of multi rounds?
> 
> > injection. Do you have any issue from your side?
> 
> I haven't hit that before, in my test, in single round, fsstress won't last long
> time (normally about 10s+ for each round).
> 
> Below is por_fsstress() implementation in my code base:
> 
> por_fsstress()
> {
>         _fs_opts
> 
>         while true; do
>                 ltp/fsstress -x "echo 3 > /proc/sys/vm/drop_caches" -X 10 -r -f fsync=8 -f sync=0 -f write=4 -f dwrite=2 -f truncate=6 -f allocsp=0 -f bulkstat=0 -f bulkstat1=0 -f freesp=0 -f zero=1 -f collapse=1 -f insert=1 -f resvsp=0 -f unresvsp=0 -S t -p 20 -n 200000 -d $TESTDIR/test &
>                 sleep 10
>                 src/godown $TESTDIR
>                 killall fsstress
>                 sleep 5
>                 umount $TESTDIR
>                 if [ $? -ne 0 ]; then
>                         for i in `seq 1 50`
>                         do
>                                 umount $TESTDIR
>                                 if [ $? -eq 0]; then
>                                         break
>                                 fi
>                                 sleep 5
>                         done
>                 fi
>                 echo 3 > /proc/sys/vm/drop_caches
>                 _fsck
>                 _mount f2fs
>                 rm $TESTDIR/testfile
>                 touch $TESTDIR/testfile
>                 umount $TESTDIR
>                 _fsck
>                 _mount f2fs
>                 _rm_50
>         done
> }
> 
> Did you update this code?
> 
> Could you share more test configuration, like mkfs option, device size, mount option,
> new por_fsstress() implementation if it exists? I can try to reproduce this issue
> in my env.

I just changed, in __run_godown_fsstress(), sleep 1000 instead of 10.

https://github.com/jaegeuk/xfstests-f2fs/blob/f2fs/run.sh#L249

./run.sh por_fsstress

> 
> Thanks,
> 
> > 
> > Thanks,
> > .
> > 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2020-05-26  2:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  1:59 [f2fs-dev] Discard issue Jaegeuk Kim
2020-05-26  2:20 ` Chao Yu
2020-05-26  2:26   ` Jaegeuk Kim [this message]
2020-05-26  7:44     ` Chao Yu
2020-05-27  1:44       ` Chao Yu
2020-05-27  1:58         ` Jaegeuk Kim
2020-05-27  2:06           ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200526022646.GA226136@google.com \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).