From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71BF0C433E0 for ; Wed, 27 May 2020 01:58:47 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32EA420787; Wed, 27 May 2020 01:58:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="hRMi/Km5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="P+r+4ypP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eUiki1sc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32EA420787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jdlLB-0005YD-Q9; Wed, 27 May 2020 01:58:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdlLA-0005Y0-Ht for linux-f2fs-devel@lists.sourceforge.net; Wed, 27 May 2020 01:58:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UuzoTOKfRf1LIekmDkk0EXpa8cJkpUfa4CnMxLVgmo8=; b=hRMi/Km57oL8IO0hak8QYd42Dc koL/9i7SXWiSq9wQiZfQ5B771PoQCyKvtM2emJD1h+CXlAIkOZl2ER7Aj7L0hrTt49Zdu3pGUqhMF saiCR5Dwut8vq6hF/62zc/lomHfP1+S923Sx/bgU/dSXWMSFDLxyEMMae5VJ1nKA8Xg8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UuzoTOKfRf1LIekmDkk0EXpa8cJkpUfa4CnMxLVgmo8=; b=P+r+4ypPGcv8N6xiDa9d+Uy/ZF 7wtVN6dKZDTpRXQkfBepV3zvh9PhuZI0ayMx5026Jh+KV5/rI/RUZ6cUWAo+3dplE7edm7y9xGbKn eYWJe1aWOZiyGiu1+i+UAQzl8nTTsDjJwGMN0/eMqgPUuATTEysaOVGLrlYQqk6yiFgU=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jdlL5-00EGwi-So for linux-f2fs-devel@lists.sourceforge.net; Wed, 27 May 2020 01:58:44 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4360220787; Wed, 27 May 2020 01:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590544698; bh=vuKLtkcSEVpeBR4HU10Ewh/w/qGaoNUlFtKsNn35R+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eUiki1scXsrR8/qvoOftHmo+n25OmIiq4uNUGyaFQOJLrv2PV2YRWaiqVOD2lxdok uJpDOuBd4azPzw8w+ljvKnb8aZGX518l2hr5Aq5inn8laVgokSGrTAkppZOcqfIYOl nTJyGm3Zgd49rx8+OWzMTaCLlOD9Eyz2WSYfz/4Q= Date: Tue, 26 May 2020 18:58:17 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: <20200527015817.GA153429@google.com> References: <20200526015917.GB207949@google.com> <9a09da49-9b3d-68c3-f47f-40bb7e4309b8@huawei.com> <20200526022646.GA226136@google.com> <36fc95db-96e1-a93b-737a-c8bf34ca00f3@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1jdlL5-00EGwi-So Subject: Re: [f2fs-dev] Discard issue X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux F2FS Dev Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/27, Chao Yu wrote: > On 2020/5/26 15:44, Chao Yu wrote: > > On 2020/5/26 10:26, Jaegeuk Kim wrote: > >> On 05/26, Chao Yu wrote: > >>> Hi Jaegeuk, > >>> > >>> On 2020/5/26 9:59, Jaegeuk Kim wrote: > >>>> Hi Chao, > >>>> > >>>> I'm hitting segment.c:1065 when running longer fsstress (1000s) with error > >>> > >>> (1000s) do you mean time in single round or total time of multi rounds? > >>> > >>>> injection. Do you have any issue from your side? > >>> > >>> I haven't hit that before, in my test, in single round, fsstress won't last long > >>> time (normally about 10s+ for each round). > >>> > >>> Below is por_fsstress() implementation in my code base: > >>> > >>> por_fsstress() > >>> { > >>> _fs_opts > >>> > >>> while true; do > >>> ltp/fsstress -x "echo 3 > /proc/sys/vm/drop_caches" -X 10 -r -f fsync=8 -f sync=0 -f write=4 -f dwrite=2 -f truncate=6 -f allocsp=0 -f bulkstat=0 -f bulkstat1=0 -f freesp=0 -f zero=1 -f collapse=1 -f insert=1 -f resvsp=0 -f unresvsp=0 -S t -p 20 -n 200000 -d $TESTDIR/test & > >>> sleep 10 > >>> src/godown $TESTDIR > >>> killall fsstress > >>> sleep 5 > >>> umount $TESTDIR > >>> if [ $? -ne 0 ]; then > >>> for i in `seq 1 50` > >>> do > >>> umount $TESTDIR > >>> if [ $? -eq 0]; then > >>> break > >>> fi > >>> sleep 5 > >>> done > >>> fi > >>> echo 3 > /proc/sys/vm/drop_caches > >>> _fsck > >>> _mount f2fs > >>> rm $TESTDIR/testfile > >>> touch $TESTDIR/testfile > >>> umount $TESTDIR > >>> _fsck > >>> _mount f2fs > >>> _rm_50 > >>> done > >>> } > >>> > >>> Did you update this code? > >>> > >>> Could you share more test configuration, like mkfs option, device size, mount option, > >>> new por_fsstress() implementation if it exists? I can try to reproduce this issue > >>> in my env. > >> > >> I just changed, in __run_godown_fsstress(), sleep 1000 instead of 10. > >> > >> https://github.com/jaegeuk/xfstests-f2fs/blob/f2fs/run.sh#L249 > >> > >> ./run.sh por_fsstress > > > > Reproducing... > > After one night reproducing, the issue still not occur.. > > BTW, I enabled below features in image: > > extra_attr project_quota inode_checksum flexible_inline_xattr inode_crtime compression > > and tagged compression flag on root inode. Could you check disk supports discard? I didn't set compression to the root inode. I set _mkfs with "f2fs": mkfs.f2fs -f -O encrypt -O extra_attr -O quota -O inode_checksum /dev/$DEV;; # run.sh reload # run.sh por_fsstress > > > > > Thanks, > > > >> > >>> > >>> Thanks, > >>> > >>>> > >>>> Thanks, > >>>> . > >>>> > >> . > >> > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > . > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel