From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C4FC433E0 for ; Thu, 11 Jun 2020 15:02:11 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27D5D20792; Thu, 11 Jun 2020 15:02:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="aTUOm3OE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Hz3R+ToI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27D5D20792 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jjOiY-0001L1-3o; Thu, 11 Jun 2020 15:02:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjOiW-0001Ks-71 for linux-f2fs-devel@lists.sourceforge.net; Thu, 11 Jun 2020 15:02:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Atbx5KRkV9iAZ2YZme7cGFVu4Hgia5eKp3Ejnouy10s=; b=aTUOm3OEjMauSR87zXNGw0cNsT BNehggblBrfwblBdWkLCFAQdyGvp+1ZysrrDx2a5LS8JeMAmxn/2zuTIAZjRPnwUAn+7g5uam2RW9 GEvRfXESDUxQvHRUkrekT4eJg64dJZn3i+8FlEp/4R+hwPVLi39ffAiIXlSEv8Oh3Itc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Atbx5KRkV9iAZ2YZme7cGFVu4Hgia5eKp3Ejnouy10s=; b=Hz3R+ToItzBUfQSdkXNyUqqs1O qPzKnAz46w5tC7tVVvjKPezKHhZeKzEqL704L6uD0z4erOc/mejnoI3PMZZNWwo1EJ/eaF/wwBg8w XutkpzIe5q6dEymsAGScJQ1+m5g0e9qtPfZhsMf7TUpdiUac2RZrHj9mT45EM6b62bUo=; Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jjOiU-00Gkca-58 for linux-f2fs-devel@lists.sourceforge.net; Thu, 11 Jun 2020 15:02:08 +0000 Received: from callcc.thunk.org (pool-100-0-195-244.bstnma.fios.verizon.net [100.0.195.244]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 05BF1oeZ025687 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jun 2020 11:01:51 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 8C5C84200DD; Thu, 11 Jun 2020 11:01:50 -0400 (EDT) Date: Thu, 11 Jun 2020 11:01:50 -0400 From: "Theodore Y. Ts'o" To: Andreas Dilger Message-ID: <20200611150150.GO1347934@mit.edu> References: <20200601200543.59417-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1jjOiU-00Gkca-58 Subject: Re: [f2fs-dev] [PATCH v2] ext4: avoid utf8_strncasecmp() with unstable name X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Rosenberg , stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , Al Viro , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Jun 01, 2020 at 02:49:51PM -0600, Andreas Dilger wrote: > On Jun 1, 2020, at 2:05 PM, Eric Biggers wrote: > > > > From: Eric Biggers > > > > If the dentry name passed to ->d_compare() fits in dentry::d_iname, then > > it may be concurrently modified by a rename. This can cause undefined > > behavior (possibly out-of-bounds memory accesses or crashes) in > > utf8_strncasecmp(), since fs/unicode/ isn't written to handle strings > > that may be concurrently modified. > > > > Fix this by first copying the filename to a stack buffer if needed. > > This way we get a stable snapshot of the filename. > > > > Fixes: b886ee3e778e ("ext4: Support case-insensitive file name lookups") > > Cc: # v5.2+ > > Cc: Al Viro > > Cc: Daniel Rosenberg > > Cc: Gabriel Krisman Bertazi > > Signed-off-by: Eric Biggers > > LGTM. > > Reviewed-by: Andreas Dilger Thanks, applied. - Ted _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel