From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBEBC433DF for ; Mon, 15 Jun 2020 17:58:23 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 727F6206F1; Mon, 15 Jun 2020 17:58:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="b9rueo5/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="UGjah5Lu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vBF2Zxx9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 727F6206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jktNG-0004w5-5C; Mon, 15 Jun 2020 17:58:22 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jktNF-0004vr-HU for linux-f2fs-devel@lists.sourceforge.net; Mon, 15 Jun 2020 17:58:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/DVT1KKJsuUqFvkFf47xqYBDJ8or9vALjKMTx11OR0Q=; b=b9rueo5/h46OrInznM+9w/r7vd PApv/YQf2k5wJEUL39WdEsZVPv37CIXjvyB6V8lruTxDh9c6p/OQ+D744m3ELZSTWkq9KC/+nBvuN 7mVqPKp7Z/xugGTqfqRLTz9UEMD9J0e7QLZJ0OwF79I+03pVW2WPNGr46gJPJHuHhLmo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/DVT1KKJsuUqFvkFf47xqYBDJ8or9vALjKMTx11OR0Q=; b=UGjah5LuTbR9z5E9TvlrBJ2X5Z 4dLN+0nmpHspIYvI2e6PTKvyycwS/42stQNYHjbNaXvu1MoeYw33QHbWryu5LnFfVTbsVo3tFJ+vu gG1cTUELLeMCA/1SeeM86C0fsi70F++k09yvuD3zRgb648EPQwsCtUrUvBoqJNxWxsi8=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jktNC-006rj5-SJ for linux-f2fs-devel@lists.sourceforge.net; Mon, 15 Jun 2020 17:58:21 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70F16206F1; Mon, 15 Jun 2020 17:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592243881; bh=sNn6POHHZDQ9IACdImpskz4O92eeG7vzTpa1ghfyuIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vBF2Zxx90O2zggkzdqrAvirH4V7LShHUF+GDy3ptW5L7oxSbyT8KVN/EdksTccAvq uehEHRNxZHyTfjZ9B8RFvonWNW/QM+E0eGz2XLZ8mOvann9+NoXAHxcX/HlQLvQocE 7gstnuq2N80VfOQLZgPpIUx6uS69D+ihemIeoGcI= Date: Mon, 15 Jun 2020 10:58:00 -0700 From: Jaegeuk Kim To: Eric Biggers Message-ID: <20200615175800.GA117170@google.com> References: <20200605181533.73113-1-efremov@linux.com> <20200609221446.24537-1-efremov@linux.com> <20200609222546.GA24766@sol.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200609222546.GA24766@sol.localdomain> X-Headers-End: 1jktNC-006rj5-SJ Subject: Re: [f2fs-dev] [PATCH v3] f2fs: use kfree() instead of kvfree() to free superblock data X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Denis Efremov , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 06/09, Eric Biggers wrote: > On Wed, Jun 10, 2020 at 01:14:46AM +0300, Denis Efremov wrote: > > Use kfree() instead of kvfree() to free super in read_raw_super_block() > > because the memory is allocated with kzalloc() in the function. > > Use kfree() instead of kvfree() to free sbi, raw_super in > > f2fs_fill_super() and f2fs_put_super() because the memory is allocated > > with kzalloc(). > > > > Fixes: 5222595d093e ("f2fs: use kvmalloc, if kmalloc is failed") > > Signed-off-by: Denis Efremov > > I don't think "Fixes" is appropriate here. Agreed. I queued this Cl without it. :) Thanks, > > kvfree() still works on kmalloc'ed memory; it's just not preferred. > > So this is more a cleanup than a fix. > > - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel