From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B18C433E7 for ; Mon, 13 Jul 2020 18:36:30 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 119F6206F0; Mon, 13 Jul 2020 18:36:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="d5hFg38r"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="JQaBuKKa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="KM7PMsU9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 119F6206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jv3JV-0003IG-2U; Mon, 13 Jul 2020 18:36:29 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jv3JT-0003I5-P6 for linux-f2fs-devel@lists.sourceforge.net; Mon, 13 Jul 2020 18:36:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TgxwhWKCCEJCn7Oev1MTPAFT7zq8gAwnfwpx6qwmZWI=; b=d5hFg38rWiYGRRcK+3UnDMBGvG uFex4KS/40OEuyvJvixmQwLIRg5WlJs4FOoafObUTOeJVyx1MHA3n6naIlcg0ahnxeT6S1Voyocf9 jvF3Tg0K3MEKHH97SLc1xCRbxQQ+UkriEVPPnWG1upYSSq/x0/7i1rRzW7eGmJWBK33k=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TgxwhWKCCEJCn7Oev1MTPAFT7zq8gAwnfwpx6qwmZWI=; b=JQaBuKKargROULbbB3OakrinI/ PminPc0SYFHOXAL+Eolr2SA3pLtwlRlw8P5RVf+4Ct0EQEKT8cnalBgPvqTXvGG9XPAlOOGjOGWAU rADbTXpQawxnosD7attWMydhj8l4HTrfCGa8nC5AvUAfuRFMJpqrYx30mMXxWLevVIiE=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jv3JS-00GRIW-N4 for linux-f2fs-devel@lists.sourceforge.net; Mon, 13 Jul 2020 18:36:27 +0000 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30864206F0; Mon, 13 Jul 2020 18:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594665381; bh=BLeUpT0iFaXku/efoG1DhWrwtysiF8mjsyAhDbJwYvY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KM7PMsU9e+2DXZLJqUFe2XogR1FnNqbehLX3k0+pOhOi5vpA45U7N7wQoDAv2d3fd c3qXgNVc47g0YliQJzKPx38hA8WIeHdc4f4jYHsyQnBOYMVLu/KOwJbE/pqKejSJYH 8azn8SCxy5mt3B+hvpZpiei6Tl7lLZ+R9SfKbQpA= Date: Mon, 13 Jul 2020 11:36:19 -0700 From: Eric Biggers To: Christoph Hellwig Message-ID: <20200713183619.GC722906@gmail.com> References: <20200709194751.2579207-1-satyat@google.com> <20200709194751.2579207-3-satyat@google.com> <20200710053406.GA25530@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200710053406.GA25530@infradead.org> X-Headers-End: 1jv3JS-00GRIW-N4 Subject: Re: [f2fs-dev] [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Satya Tangirala Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Jul 10, 2020 at 06:34:06AM +0100, Christoph Hellwig wrote: > On Thu, Jul 09, 2020 at 07:47:48PM +0000, Satya Tangirala wrote: > > From: Eric Biggers > > > > Set bio crypt contexts on bios by calling into fscrypt when required, > > and explicitly check for DUN continuity when adding pages to the bio. > > (While DUN continuity is usually implied by logical block contiguity, > > this is not the case when using certain fscrypt IV generation methods > > like IV_INO_LBLK_32). > > I know it is asking you for more work, but instead of adding more > features to the legacy direct I/O code, could you just switch the user > of it (I guess this is for f2f2?) to the iomap one? Eventually we should do that, as well as convert f2fs's fiemap, bmap, and llseek to use iomap. However there's a nontrivial barrier to entry, at least for someone who isn't an expert in iomap, especially since f2fs currently doesn't use iomap at all and thus doesn't have an iomap_ops implementation. And using ext4 as an example, there will be some subtle cases that need to be handled. Satya says he's looking into it; we'll see what he can come up with and what the f2fs developers say. If it turns out to be difficult and people think this patchset is otherwise ready, we probably shouldn't hold it up on that. This is a very small patch, and Satya and I have to maintain it for years in downstream kernels anyway, so it will be used and tested regardless. It would also be nice to allow userspace (e.g. xfstests) to assume that if the inlinecrypt mount option is supported, then direct I/O is supported too, without having to handle intermediate kernel releases where inlinecrypt was supported but not direct I/O. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel