From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F20C433E0 for ; Wed, 22 Jul 2020 16:44:11 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58B7B206C1; Wed, 22 Jul 2020 16:44:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="msTlbJlI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="kOlnzSeA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pr3QGSqD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58B7B206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jyHqk-0007QT-41; Wed, 22 Jul 2020 16:44:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyHqi-0007QM-Pe for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Jul 2020 16:44:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Zk6F4uVbnUf2oeUv7IyzfV0lTr1Y6rY+tsb9k25LoDE=; b=msTlbJlINtpElLSWKEr5vG3zRE OSsZ9i34wQa3WSqEPWLXHWzAsBsjN+veNa8Q7MQtM5YyDo/vYciBDfCdp8Xa4NaPAskobP459COoB vSLD7JhX4OCBM0UZNbyDiA8FoFeED/19zLRBKfPwFzml6Ql49r98F9a0Orxgptsc67eM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Zk6F4uVbnUf2oeUv7IyzfV0lTr1Y6rY+tsb9k25LoDE=; b=kOlnzSeAddJaNK1a7tBzJBDxAE b1xIDW8OLv373nl3WeWgQXBbYWpz/+FCtJw3olc+X5LZ/Z1cTrlXlJlKiKyVnD9fnLqqP45RI3waO E2FBQjNU0XaIgVgH+3FDyY60xjd08A3sXjH7K3dr5D/kuMoijASSaARpFYIHA82O9PkI=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jyHqh-004yHu-MD for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Jul 2020 16:44:08 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D04C206C1; Wed, 22 Jul 2020 16:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595436236; bh=NWmgMsYz/UjEHMAobNjaiLofiShGglCnNsamdsb/4Rc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pr3QGSqDxjAvr5aSuvlajCCX0H8+kOeWvKsF32hJUChoXnX2+zQhaEqT51FsiyMl+ QLaeEso28PHOmuS30c82ZfXTzIOb5GnXtq3aqJehFW3rr3TY3PShXks9vry8e4pDJi vhAajRuY/QG1uuNzvGDLZHSu7wgR+RnkLbA1z/Lw= Date: Wed, 22 Jul 2020 09:43:56 -0700 From: Jaegeuk Kim To: Greg KH Message-ID: <20200722164356.GA3912099@google.com> References: <20200719054409.3050516-1-daeho43@gmail.com> <20200719151640.GA301791@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200719151640.GA301791@kroah.com> X-Headers-End: 1jyHqh-004yHu-MD Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: add sysfs symbolic link to kobject with volume name X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 07/19, Greg KH wrote: > On Sun, Jul 19, 2020 at 02:44:08PM +0900, Daeho Jeong wrote: > > From: Daeho Jeong > > > > Added a symbolic link directory pointing to its device name > > directory using the volume name of the partition in sysfs. > > (i.e., /sys/fs/f2fs/vol_#x -> /sys/fs/f2fs/sda1) > > No, please no. > > That is already created today for you in /dev/disk/ The kernel does not > need to do this again. > > If your distro/system/whatever does not provide you with /dev/disk/ and > all of the symlinks in there, then work with your distro/system/whatever > to do so. I don't get the point, since /dev/disk points device node, not any sysfs entry. Do you mean we need to create symlink to /sys/fs/f2fs/dm-X in /dev/disk? > > Again, no need to do this on a per-filesystem-basis when we already have > this around for all filesystems, and have had it for 15+ years now. Could you point out where we can get this? And, the label support depends on per-filesystem design. I'm not sure how this can be generic enough. > > thanks, > > greg k-h _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel