From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35CEBC4363D for ; Wed, 7 Oct 2020 21:53:21 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 842D720882 for ; Wed, 7 Oct 2020 21:53:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Oh7tBHyJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="bhHxLif/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YnxFOdeN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 842D720882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kQHN9-0003TX-AX; Wed, 07 Oct 2020 21:53:19 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQHN7-0003TM-Br for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Oct 2020 21:53:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IROItl7OlMPxQnbJUXcWWtr551eHF5bfWJHypgCBcaQ=; b=Oh7tBHyJeMkZIuH6Xxkbmb0w3w qFqdharb3llcEpm2Hf/CwzP1eyUc9oZYuDXQZdwDWlI5hh1rFGbC5aurYcMN5NHtr4sclDuCKPCh0 OQKc+4kUCxLlJkmxv0MCJqmRgAZGkPKdBY18M/1e3haLwjUSE7TdtvymCHWXZHg7SBhs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IROItl7OlMPxQnbJUXcWWtr551eHF5bfWJHypgCBcaQ=; b=bhHxLif/k01tghy9A3tmqRUQkn FDXMkascnVGfyCHCLYmv5fmIV/mCd83CH1T1IDTmcMP144ChBZJdHIcde7ZECdTPPMrJpe8KX8xRj k8OVis/QaUS6kB+iikvJu0koOJ55CvT2fRvf8zEuGDgcj1+G3P+TZc2ZD4spUCS9Gssk=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kQHN2-006Vp4-6e for linux-f2fs-devel@lists.sourceforge.net; Wed, 07 Oct 2020 21:53:17 +0000 Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F3732083B; Wed, 7 Oct 2020 21:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602107586; bh=MPd+m+gOLhyTzVCwh1CGngmTmB7inK08d900/ooQw9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YnxFOdeNEKmQJdA5hETP2QGSDLr/fCGuUC9/1xgIQl+np7cqXuRCiQQaM2GvsmRRh ez1hPfv5bD5jjNNanaYgG3D+i+t+oAemCw+0Cv63eCgSd+VJ15urbTIh32t06eCEMO ZCvbQLL/TeJAdIT0860MmhjRRkXTShnCH6kllMb8= Date: Wed, 7 Oct 2020 14:53:05 -0700 From: jaegeuk@kernel.org To: Eric Biggers Message-ID: <20201007215305.GA714500@google.com> References: <000000000000432c5405b1113296@google.com> <20201007213253.GD1530638@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201007213253.GD1530638@gmail.com> X-Headers-End: 1kQHN2-006Vp4-6e Subject: Re: [f2fs-dev] [f2fs bug] infinite loop in f2fs_get_meta_page_nofail() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syzbot+ee250ac8137be41d7b13@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 10/07, Eric Biggers wrote: > [moved linux-fsdevel to Bcc] > > On Wed, Oct 07, 2020 at 02:18:19AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: a804ab08 Add linux-next specific files for 20201006 > > git tree: linux-next > > console output: https://syzkaller.appspot.com/x/log.txt?x=17fe30bf900000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=26c1b4cc4a62ccb > > dashboard link: https://syzkaller.appspot.com/bug?extid=ee250ac8137be41d7b13 > > compiler: gcc (GCC) 10.1.0-syz 20200507 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1336413b900000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12f7392b900000 > > > > The issue was bisected to: > > > > commit eede846af512572b1f30b34f9889d7df64c017d4 > > Author: Jaegeuk Kim > > Date: Fri Oct 2 21:17:35 2020 +0000 > > > > f2fs: f2fs_get_meta_page_nofail should not be failed > > > > Jaegeuk, it looks like the loop you added in the above commit doesn't terminate > if the requested page is beyond the end of the device. Yes, that will go infinite loop. Otherwise, it will trigger a panic during the device reboot. Let me think how to avoid that before trying to get the wrong lba access. > > - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel