From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid unneeded data copy in f2fs_ioc_move_range()
Date: Mon, 9 Nov 2020 09:00:35 -0800 [thread overview]
Message-ID: <20201109170035.GA2129970@google.com> (raw)
In-Reply-To: <20201109165914.2118360-1-jaegeuk@kernel.org>
Sorry, please ignore this.
On 11/09, Jaegeuk Kim wrote:
> From: Chao Yu <yuchao0@huawei.com>
>
> Fields in struct f2fs_move_range won't change in f2fs_ioc_move_range(),
> let's avoid copying this structure's data to userspace.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/file.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 52417a2e3f4f..22ae8ae0072f 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2898,12 +2898,6 @@ static int f2fs_ioc_move_range(struct file *filp, unsigned long arg)
> range.pos_out, range.len);
>
> mnt_drop_write_file(filp);
> - if (err)
> - goto err_out;
> -
> - if (copy_to_user((struct f2fs_move_range __user *)arg,
> - &range, sizeof(range)))
> - err = -EFAULT;
> err_out:
> fdput(dst);
> return err;
> --
> 2.29.2.222.g5d2a92d10f8-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2020-11-09 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 16:59 [f2fs-dev] [PATCH] f2fs: avoid unneeded data copy in f2fs_ioc_move_range() Jaegeuk Kim
2020-11-09 17:00 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109170035.GA2129970@google.com \
--to=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).