From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB587C433DB for ; Fri, 8 Jan 2021 09:10:58 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CD5E22248; Fri, 8 Jan 2021 09:10:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CD5E22248 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kxnnM-0005xd-O8; Fri, 08 Jan 2021 09:10:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxnnI-0005xO-2B for linux-f2fs-devel@lists.sourceforge.net; Fri, 08 Jan 2021 09:10:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9a3ViyxTrkZcaeAEmwjzXZxQfdA0ohtTnQ+xJKGn41w=; b=TqDHLM06SokC+2ySsZZZyFtd5n Vnk5iD/NT4utUbUyFiyPAFvtEVZ6cHMX2siIM6MLEqx7SmLAZw86IKyIwH2bc5veUEO+0uKc0H07X oLVYO/vMS2zf4y1i7qxfg3tNa5Zbce0dkiSThV3BtVNJOn8JgihxyPYZJ1PNRYihFRpo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9a3ViyxTrkZcaeAEmwjzXZxQfdA0ohtTnQ+xJKGn41w=; b=A1G3GhbL1ZnyFmILd6Y897AxLU FnI2UmKF8CbCk+2K2lvf8V4zdIFFxiMl20PioBCiB4KYcmQJOWUOoUuM7uQHc4yYc0eEN5FX8FPad PUhaXz34wcQBCpJESyrgwkgx9Z/bDJ6ORM/ZlOpaXkRPPM+41du2AaBkBxKUB81btnt0=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kxnnE-00GpYA-VQ for linux-f2fs-devel@lists.sourceforge.net; Fri, 08 Jan 2021 09:10:52 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E6BBB67373; Fri, 8 Jan 2021 09:54:32 +0100 (CET) Date: Fri, 8 Jan 2021 09:54:32 +0100 From: Christoph Hellwig To: Eric Biggers Message-ID: <20210108085432.GA1438@lst.de> References: <20210105005452.92521-1-ebiggers@kernel.org> <20210105005452.92521-2-ebiggers@kernel.org> <20210107144709.GG12990@quack2.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1kxnnE-00GpYA-VQ Subject: Re: [f2fs-dev] [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Theodore Ts'o , linux-ext4@vger.kernel.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jan 07, 2021 at 01:46:37PM -0800, Eric Biggers wrote: > It looks like that's going to work, and it fixes the XFS bug too. > > Note that if __writeback_single_inode() is called from writeback_single_inode() > (rather than writeback_sb_inodes()), then the inode might not be queued for > sync, in which case mark_inode_dirty_sync() will move it to a writeback list. > > That's okay because afterwards, writeback_single_inode() will delete the inode > from any writeback list if it's been fully cleaned, right? So clean inodes > won't get left on a writeback list. > > It's confusing because there are comments in writeback_single_inode() and above > __writeback_single_inode() that say that the inode must not be moved between > writeback lists. I take it that those comments are outdated, as they predate > I_SYNC_QUEUED being introduced by commit 5afced3bf281 ("writeback: Avoid > skipping inode writeback")? Yes. I think we need to update the comment as well. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel