From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CEFC433DB for ; Fri, 12 Feb 2021 22:33:57 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A854B64DFF; Fri, 12 Feb 2021 22:33:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A854B64DFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lAh0c-0006q6-DC; Fri, 12 Feb 2021 22:33:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAh0b-0006pz-Cd for linux-f2fs-devel@lists.sourceforge.net; Fri, 12 Feb 2021 22:33:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QcNFNrFbEBWBhSBFM0Vkguq1AuFyie7eyNXMcuoiCtA=; b=d+njBv8n2PiSmefyO2QNy6u1FN w3jAPN93TtgHrJ+h+BRj0sMjwH4f9Dj2IBZPPKJ82QCqwJVQLTR3lwdV0Fsty4tx268gq/iSU6i0y J2pkuZoQ2y1ZvYsq+fWNUCUlCm22JZWK5ugAlRo1NnO1ZAMw6i2uoSDyucwLmZkTDJgw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=QcNFNrFbEBWBhSBFM0Vkguq1AuFyie7eyNXMcuoiCtA=; b=C W/VeALoz/SkQtRPtW3OgtemmobZNzW32iNF9MyRDyusiByjIxzeSqA/YtKeOjZ4oELjtfzpxEu/pK YT8yvpNN0KNIrD5NFsSnJSleHiFYUPlVklTQjEGQl6CqaP7PQ+2wWgCE7i9vvB8zCKJ4W7tqYdWEl 8raObVOopOrDPAZs=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1lAh0X-006kle-4n for linux-f2fs-devel@lists.sourceforge.net; Fri, 12 Feb 2021 22:33:53 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A406864DA1; Fri, 12 Feb 2021 22:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613169218; bh=zPLaLMvsfWolU7A16h5AwBVtaAqZZp8VsJK9aSEF+Oc=; h=From:To:Cc:Subject:Date:From; b=bz6gNxSjE+LWAL4HXxQHIymg3n3+zD6JqskLilyqGZ5jqrCqJZvHk9NWo0CNc7huw yKpW+I6iavEVqoSSgOO3TiJnXPmvDzNZC4MszJTW1VdhgewpuLure/rWoZMD1BSCA9 Xott4J6YPohZZYrMGQEKQ5mm3UL5MKefqqGxP/Xc4V44YkLR7xzEgq/u8zZeVTLA7G 5M4ApIfpA4FWYB4dXI+uQKsKUhTG6I4EGJ7QfT04sQbYUtlFCaMmWeLFALRgEqqbwm 6nGWGwp8O/FWZ7mK0Dm4b6x4rmjpUfcbR2OKdlVqHJAELOTQh49C9qBxgZEgn+56XC OTw1KVO6nD28g== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Date: Fri, 12 Feb 2021 14:33:34 -0800 Message-Id: <20210212223334.3550799-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.30.0.478.g8a0d178c01-goog MIME-Version: 1.0 X-Headers-End: 1lAh0X-006kle-4n Subject: [f2fs-dev] [PATCH] f2fs: give a warning only for readonly partition X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Let's allow mounting readonly partition. We're able to recovery later once we have it as read-write back. Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 4aa533cb4340..30d5abef4361 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -3933,12 +3933,10 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) * previous checkpoint was not done by clean system shutdown. */ if (f2fs_hw_is_readonly(sbi)) { - if (!is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG)) { - err = -EROFS; + if (!is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG)) f2fs_err(sbi, "Need to recover fsync data, but write access unavailable"); - goto free_meta; - } - f2fs_info(sbi, "write access unavailable, skipping recovery"); + else + f2fs_info(sbi, "write access unavailable, skipping recovery"); goto reset_checkpoint; } -- 2.30.0.478.g8a0d178c01-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel