From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 442ABC4338F for ; Wed, 18 Aug 2021 14:58:28 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CEDD610CB; Wed, 18 Aug 2021 14:58:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0CEDD610CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mGN1O-0007YK-UB; Wed, 18 Aug 2021 14:58:26 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGN1N-0007YE-FW for linux-f2fs-devel@lists.sourceforge.net; Wed, 18 Aug 2021 14:58:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AdDChgYKFP5pDXKjILxzg9xwSt+lGrgGqLpKDvBxBd0=; b=QJBljwcsRASBdUAqloxCUke6VL w+Dfrqr3umaoHjLCmWb5BzToXOJDiR/E5n+IJvfuZDtslNQG1cjTMG0vOZFHvjwuE5P0j3yT8Q/1B RbJ14qRvsgBwUTHX0SW3CdCy4G1KMBtNQ6KfZFwyB5Y/E0XgPrMRCKK98SE41aD9F1+I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AdDChgYKFP5pDXKjILxzg9xwSt+lGrgGqLpKDvBxBd0=; b=SQWzyc33ziMhu1Zb1Z5oSb5BeM JAoZcTBskVSIjDGJBBi1Onz8Pz/xuLTHQ8jOfF1LTnScfAzDsW8KVKAC+7yFTFONY7F1Wlgy6oX26 FKCYx8PC8DJSLnvUv3T0M75tW6DbJ544IyeEQIo8QafeNNKM2LyoUjgphcgGfrU2P3oM=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mGN1L-00027w-NB for linux-f2fs-devel@lists.sourceforge.net; Wed, 18 Aug 2021 14:58:25 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 1787E67373; Wed, 18 Aug 2021 16:58:14 +0200 (CEST) Date: Wed, 18 Aug 2021 16:58:13 +0200 From: Christoph Hellwig To: Matthew Wilcox Message-ID: <20210818145813.GA13343@lst.de> References: <20210818140651.17181-1-hch@lst.de> <20210818140651.17181-12-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1mGN1L-00027w-NB Subject: Re: [f2fs-dev] [PATCH 11/11] unicode: only export internal symbols for the selftests X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gabriel Krisman Bertazi , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Shreeya Patel , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Aug 18, 2021 at 03:56:59PM +0100, Matthew Wilcox wrote: > On Wed, Aug 18, 2021 at 04:06:51PM +0200, Christoph Hellwig wrote: > > The exported symbols in utf8-norm.c are not needed for normal > > file system consumers, so move them to conditional _GPL exports > > just for the selftest. > > Would it be better to use EXPORT_SYMBOL_NS_GPL()? Maybe. Even better would be the EXPORT_SYMBOL_FOR I've been prototyping for a while but which is still not ready. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel