From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631D5C433F5 for ; Fri, 10 Sep 2021 00:19:02 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2438C611CA for ; Fri, 10 Sep 2021 00:19:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2438C611CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mOUFx-0001Wy-6F; Fri, 10 Sep 2021 00:19:01 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOUFv-0001Wr-Qk for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Sep 2021 00:18:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5PgKBd6QfL3eqHC+MLGtSuho/WKziwAUs7vX8/bRd/A=; b=IqDvnszC6y+s9o1hQEHzbK8ydR RB+GNBhkWcYVVg2Pm8oqYk8aZ6kagNtJsvhGGCeBqzQGTu087tsm05zKS4NX4WCRgs0mkZnky9KFH /4F8B40FsJhX2keKYlCJB07SG8bsel88vSuqu7o89zkMX4l7H4fMEurFpbeUfyzqtk+o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5PgKBd6QfL3eqHC+MLGtSuho/WKziwAUs7vX8/bRd/A=; b=lCeTFiPOeiZB4zQRvovhtNKu17 eaCpgMQVM9aPGu8XKE/x/Qkx5sCfzp2fKLi4szaToDffGz7jMmGCfcWBkT+baJhFySXNdVuhnOYLT W9qNeUhNcDyLxfddRhseINyH4wp+BIlXaBK2+2QabdI3fsW/Nbbx2b2eLeQ6ZqE80YdE=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mOUFv-005S1G-9Z for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Sep 2021 00:18:59 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1721611C8; Fri, 10 Sep 2021 00:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233133; bh=nPoeR/Xk1IwI8b2b+g7ewNYQ1oq35N3ObNd00YuEkk0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p4DpZn5QVQb9UEpg8ho9gWXra+KxhAoTybU5qkWpDeADi7p8WtdETE+DFMq64tMXr GV9AyU+WIKOVY4BD8/8JBzbmiSEds8TkcQOp9BHBlJ3Gj3vmM6cp1pII4DD+Ii31J6 CwU69qOV04v1WlnsjLVIuCjkghKOJZpk++/oxmTGcMHYNO/MNNS4Jcm2K9Nfy4n0Zz QvRM6f6xfJftuz2fizGfl55L/i+4WUOOVcj4mrJ2d/k1EBez4teihxHTRkTt+upBrS oiBH3qVGVX2BTJiOtOsOxYPn3ij1DNpWXJ/F062rRBpJ6xGAIQJbrU2dNFdQdFN1So 1M8W/xPpLHAAA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Thu, 9 Sep 2021 20:17:15 -0400 Message-Id: <20210910001820.174272-23-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001820.174272-1-sashal@kernel.org> References: <20210910001820.174272-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-Headers-End: 1mOUFv-005S1G-9Z Subject: [f2fs-dev] [PATCH AUTOSEL 5.13 23/88] f2fs: fix to force keeping write barrier for strict fsync mode X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Chao Yu [ Upstream commit 2787991516468bfafafb9bf2b45a848e6b202e7c ] [1] https://www.mail-archive.com/linux-f2fs-devel@lists.sourceforge.net/msg15126.html As [1] reported, if lower device doesn't support write barrier, in below case: - write page #0; persist - overwrite page #0 - fsync - write data page #0 OPU into device's cache - write inode page into device's cache - issue flush If SPO is triggered during flush command, inode page can be persisted before data page #0, so that after recovery, inode page can be recovered with new physical block address of data page #0, however there may contains dummy data in new physical block address. Then what user will see is: after overwrite & fsync + SPO, old data in file was corrupted, if any user do care about such case, we can suggest user to use STRICT fsync mode, in this mode, we will force to use atomic write sematics to keep write order in between data/node and last node, so that it avoids potential data corruption during fsync(). Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/file.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index ceb575f99048..e78a7d9888c8 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -303,6 +303,18 @@ static int f2fs_do_sync_file(struct file *file, loff_t start, loff_t end, f2fs_exist_written_data(sbi, ino, UPDATE_INO)) goto flush_out; goto out; + } else { + /* + * for OPU case, during fsync(), node can be persisted before + * data when lower device doesn't support write barrier, result + * in data corruption after SPO. + * So for strict fsync mode, force to use atomic write sematics + * to keep write order in between data/node and last node to + * avoid potential data corruption. + */ + if (F2FS_OPTION(sbi).fsync_mode == + FSYNC_MODE_STRICT && !atomic) + atomic = true; } go_write: /* -- 2.30.2 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel