From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95110C433F5 for ; Fri, 12 Nov 2021 21:32:44 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D39C60E08; Fri, 12 Nov 2021 21:32:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D39C60E08 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mleA6-0006Kg-Gj; Fri, 12 Nov 2021 21:32:42 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mleA5-0006Ka-I0 for linux-f2fs-devel@lists.sourceforge.net; Fri, 12 Nov 2021 21:32:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7bYQarVRKy5eL45qiskZyCgtIIcWrGULW7wSUHVggXI=; b=MYwDTLo/DU4cBOkQmJEQVeHjs/ qtX89w+bkcFinFcGQYA130bU5ve66CPv6uPz/BqiiJaV+vtGRs4tpupXJUcC0J3aqVWg0sZWE52tV R1MSAAWhoTLKrtnXriD61XrRx2A7rvtW25uwsiht5n7IA0ZBO0WnDuBE8QNBleRMdcMI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=7bYQarVRKy5eL45qiskZyCgtIIcWrGULW7wSUHVggXI=; b=M GZJWLRxpzmxFzooDwQeJ349Ub56ZD1pRRAIzpPjOWXP9mJPd1V5D2WLhi2uYVROEyXya+gcHqgKac ZWFb6SVkyQQgPBdB7I4Zd9pBirIlR2gfx49gluFSx/4CK48HkrrngRm+r+gpSKM7H/zAjmFeWnCHd ddECVsLL3Kv3lQ5U=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mleA5-0001N6-11 for linux-f2fs-devel@lists.sourceforge.net; Fri, 12 Nov 2021 21:32:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8223360EFD; Fri, 12 Nov 2021 21:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636752755; bh=tT2rrkB4j3yoXxgi1WqPEOPL25m2M20otAFbBpBTVXw=; h=From:To:Cc:Subject:Date:From; b=shsw6PslE7j1QBmC1LlfrJGPEWV4roKPAYaNLia0TwHytAz9AWd+WF0plDSuMSkXW +urym2VQi281NxrO/RyyKhhJtUGACEem45jiJgKDC/Okxzds20oLm04YPSymwUEhAQ LfJOIN95FJ4b1Pwh8T0y6R4R4sxj1CzSCXtDc1Pqh2FljlAPk2hTR2/uvwbQknhj7K v58zQFvZrIJcPDaCmjn/zR0JVXC+vMp3loUhI+IiqZvwa0xVBsr4ufiGG06oK0goO1 t/5rkU8AGrE6RQLt6xxmVqWweePDdedV9xVWwJo8DN+wUZiXlXqj1jaCwsPxymcaRN GIZ3xgKVLB8+A== From: Jaegeuk Kim To: linux-f2fs-devel@lists.sourceforge.net Date: Fri, 12 Nov 2021 13:32:31 -0800 Message-Id: <20211112213231.2483419-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.34.0.rc1.387.gb447b232ab-goog MIME-Version: 1.0 X-Headers-End: 1mleA5-0001N6-11 Subject: [f2fs-dev] [PATCH] fsck.f2fs: do not assert if i_size is missing i_blocks in symlink X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net This case is not a bug, so we should fix seamlessly. Signed-off-by: Jaegeuk Kim --- fsck/fsck.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 0619519f9b42..ecd87af0ff7f 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@ -1131,14 +1131,10 @@ skip_blkcnt_fix: if (ftype == F2FS_FT_SYMLINK && i_size == 0 && i_blocks == (i_xattr_nid ? 3 : 2)) { - ASSERT_MSG("ino: 0x%x i_blocks: %lu with zero i_size\n", - nid, (unsigned long)i_blocks); - if (c.fix_on) { - node_blk->i.i_size = cpu_to_le64(F2FS_BLKSIZE); - need_fix = 1; - FIX_MSG("Symlink: recover 0x%x with i_size=%lu", + node_blk->i.i_size = cpu_to_le64(F2FS_BLKSIZE); + need_fix = 1; + FIX_MSG("Symlink: recover 0x%x with i_size=%lu", nid, (unsigned long)F2FS_BLKSIZE); - } } if (ftype == F2FS_FT_ORPHAN && i_links) { -- 2.34.0.rc1.387.gb447b232ab-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel