From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D62CDC433EF for ; Tue, 15 Feb 2022 22:01:01 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nK5sa-0007Af-AS; Tue, 15 Feb 2022 22:00:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nK5sY-0007AY-8z for linux-f2fs-devel@lists.sourceforge.net; Tue, 15 Feb 2022 22:00:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IDpwMUIF+jWhMgNjkOKNSe7czv2N2UjhgBr2DYG6VQw=; b=E75ejIbT1yc2xY87G80DZc8v4U 3wukHDsDZe8a0ctUFXVkfx62xPEFcQk4qlXGjv9XG4tzMVnbwRVV29CBO0CoGuG4/UaBi1rN5BhYZ Z8/1rXJ4e9Rz2Oygp3Y5lIUibW2301f5778HvRHM4XWXOmdqsrxqmgRHUYs0wmf3Z6JY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=IDpwMUIF+jWhMgNjkOKNSe7czv2N2UjhgBr2DYG6VQw=; b=F yS7sWej07xUU3EDuyqHog2gIO8M5bKgJ1tKAX6jS+IvJHqTbkZPB+eYBJQ7pLxxm8QPUqIeKsORPs 3WNYYByEHJDAP9hVpzFQUuYC63Xr2gk46Y0WU28LG7r1HfKkAqRRIAYh7vhxS1Yhq2zhqUzjs3O2a GYHQ7tO657NDfjDs=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nK5sR-0039HC-Cw for linux-f2fs-devel@lists.sourceforge.net; Tue, 15 Feb 2022 22:00:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33BD561941 for ; Tue, 15 Feb 2022 22:00:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1D72C340EC; Tue, 15 Feb 2022 22:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644962441; bh=X8r4q2p+p6NNB71zOmj7oDzhexfHoB4kLO7Gj/1f7n8=; h=From:To:Cc:Subject:Date:From; b=YlEQQm2Tl7WgnabmYFw5fxB4OI+zjyEbJNEdi+hqKU53zdakMQEYNXuPp9asD6nOk 88IOWR0Tcid2KYgdXsTQYA3+b//haFnbcR2H5J3K58QF7VCnN7qjB4a7uki27cja+T 73eQNJMWbk2UW970EDoE3wK1/HS+jT1sv7WGF9Yem7elkmTkOjWy/66yCi5DnnD0fy 5bXZ1Qp/3S9TNUMmQd+p1vFSmpmjNgNuV3hmIXLgbDT8KDkYXQvZAwGIBarFEhrUMj PoN4FQYDJE1FJznbxx1qF6lhxSWGwy4mi+jQGg33W2gZTCdZXQ0kq1cbI7L1PAggCQ W9hRdCN9owOgg== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Tue, 15 Feb 2022 14:00:39 -0800 Message-Id: <20220215220039.1477906-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog MIME-Version: 1.0 X-Headers-End: 1nK5sR-0039HC-Cw Subject: [f2fs-dev] [PATCH] f2fs: avoid sb_start_intwrite during eviction X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net 1. this thread is stuck in f2fs_evict_inode by #2: [210757.653718] __schedule+0x2e3/0x740 [210757.654811] schedule+0x42/0xb0 [210757.655829] rwsem_down_read_slowpath+0x16c/0x4a0 [210757.657161] __down_read+0x6b/0x80 [210757.658254] __percpu_down_read+0x54/0x80 [210757.659413] __sb_start_write+0x79/0x80 [210757.660546] f2fs_evict_inode+0x354/0x5c0 [f2fs] [210757.661808] ? var_wake_function+0x30/0x30 [210757.663016] evict+0xd2/0x1b0 [210757.664007] dispose_list+0x39/0x50 [210757.665083] prune_icache_sb+0x5c/0x80 [210757.666226] super_cache_scan+0x132/0x1b0 [210757.667373] do_shrink_slab+0x150/0x2a0 [210757.668510] shrink_slab+0x20c/0x2a0 [210757.669574] drop_slab_node+0x33/0x60 [210757.670646] drop_slab+0x3e/0x70 [210757.671633] drop_caches_sysctl_handler+0x75/0x85 [210757.672904] proc_sys_call_handler+0x1a2/0x1c0 [210757.674104] proc_sys_write+0x14/0x20 [210757.675189] __vfs_write+0x1b/0x40 [210757.676208] vfs_write+0xb9/0x1a0 [210757.677219] ksys_write+0x67/0xe0 [210757.678251] __x64_sys_write+0x1a/0x20 2. another thread is waiting for #1: [210757.754646] schedule+0x42/0xb0 [210757.755680] rwsem_down_write_slowpath+0x244/0x4d0 [210757.757016] ? _cond_resched+0x19/0x30 [210757.758140] down_write+0x41/0x50 [210757.759223] prealloc_shrinker+0x6a/0x120 [210757.760397] alloc_super+0x275/0x2d0 [210757.761500] sget_fc+0x74/0x220 [210757.762547] ? set_anon_super+0x20/0x20 [210757.763711] ? shmem_create+0x20/0x20 [210757.764842] vfs_get_super+0x3d/0x100 [210757.765925] get_tree_nodev+0x16/0x20 [210757.767046] shmem_get_tree+0x15/0x20 [210757.768165] vfs_get_tree+0x2a/0xc0 [210757.769248] ? ns_capable+0x10/0x20 [210757.770361] do_mount+0x7b6/0x9c0 [210757.771423] ksys_mount+0x82/0xd0 [210757.772469] __x64_sys_mount+0x25/0x30 [210757.773592] do_syscall_64+0x57/0x190 3. thaw_super is waiting for #2, resulting in xfstests/generic/068 being stuck. [210757.695823] __schedule+0x2e3/0x740 [210757.696897] ? sched_clock+0x9/0x10 [210757.697959] schedule+0x42/0xb0 [210757.698963] rwsem_down_write_slowpath+0x244/0x4d0 [210757.700247] down_write+0x41/0x50 [210757.701259] thaw_super+0x17/0x30 [210757.702235] do_vfs_ioctl+0x56f/0x670 [210757.703247] ? do_user_addr_fault+0x216/0x450 [210757.704395] ? _copy_to_user+0x2c/0x30 [210757.705443] ksys_ioctl+0x67/0x90 [210757.706419] __x64_sys_ioctl+0x1a/0x20 [210757.707437] do_syscall_64+0x57/0x190 Signed-off-by: Jaegeuk Kim --- fs/f2fs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index ab8e0c06c78c..882db4bd917b 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -778,7 +778,6 @@ void f2fs_evict_inode(struct inode *inode) f2fs_remove_ino_entry(sbi, inode->i_ino, UPDATE_INO); f2fs_remove_ino_entry(sbi, inode->i_ino, FLUSH_INO); - sb_start_intwrite(inode->i_sb); set_inode_flag(inode, FI_NO_ALLOC); i_size_write(inode, 0); retry: @@ -809,7 +808,6 @@ void f2fs_evict_inode(struct inode *inode) if (dquot_initialize_needed(inode)) set_sbi_flag(sbi, SBI_QUOTA_NEED_REPAIR); } - sb_end_intwrite(inode->i_sb); no_delete: dquot_drop(inode); -- 2.35.1.265.g69c8d7142f-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel