From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 449B7C433F5 for ; Tue, 19 Apr 2022 21:57:20 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1ngvqY-0005lz-3X; Tue, 19 Apr 2022 21:57:17 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ngvqW-0005lt-IO for linux-f2fs-devel@lists.sourceforge.net; Tue, 19 Apr 2022 21:57:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MTNI0XB1tzAEaq1u03KZ+KGvWfVfgypHylWI7IOzW78=; b=BZ8c7ah1XTDj2f4NjFuPFmkmWV EGyMChEW3Pi/pOPug5pzIGW8UWdwMnGKVd+Tl8Ml0YXn3OF73KvGDZw+RDl1rA0k4uxY+nt8n914h SEue2NbTuGGy3mN3erTqgAdOjNom8GxY8xkSmEJfoX2rUqeGSYwjf9yKiMq9yOdMAw6s=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=MTNI0XB1tzAEaq1u03KZ+KGvWfVfgypHylWI7IOzW78=; b=X HAA6dMbK9vdZ0p9OV72xKduQ1cKwnPBOEKL5dcYziB1DzFXwD29rP3hVXXnnJkh0Sr7NFcfS3BDGX nw+7raVRJ7FZEBtrNKmjRSJs12EodYSh83hPQ4sDKOJFIV6us7XLblEzhteQpto9w1UR8H+wboA+A Gp8f9MQ1EEool7Qs=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1ngvqU-004DFI-VN for linux-f2fs-devel@lists.sourceforge.net; Tue, 19 Apr 2022 21:57:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE41F617BA for ; Tue, 19 Apr 2022 21:57:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8239AC385A7; Tue, 19 Apr 2022 21:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650405424; bh=kvg9SXGdehN1yOUx+2cqBh0ZkhYF9DmxMqwB+3v5TRY=; h=From:To:Cc:Subject:Date:From; b=FhDIRLS2h0svfjr2wUFu6dKceIwBtTeYDlXfEG2hYER1g6bhyhUV0YwByzPI3HP1P ofvp4mrRiTMElQRuvcz3vGHMCbZ+l3mAasdHUELl6QKizFhvOj+nMfJdQrHEx4oVm3 x/AU2g++u/xAom9mU7ihOkN4+U+xTMnatk2/lNCFBfVp/VXajUh+kxNtf9g3w8ngXw tmdVHXeHtsmqyZRUkM4S/aHcECet9RxEt7Wjl/JBY87UccD/z8TftMJc2PVtMI6eNo 7DT6v+H8PRmaEdvlqrD7DAnFWvTjaW9XMQU2TqGXxpPfwJkHxyzslhxSbmfF3jPrGy NxKq+Zpzsd6vw== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Tue, 19 Apr 2022 14:57:03 -0700 Message-Id: <20220419215703.1271395-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.36.0.rc0.470.gd361397f0d-goog MIME-Version: 1.0 X-Headers-End: 1ngvqU-004DFI-VN Subject: [f2fs-dev] [PATCH] f2fs: use flush command instead of FUA for zoned device X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net The block layer for zoned disk can reorder the FUA'ed IOs. Let's use flush command to keep the write order. Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 4 +++- fs/f2fs/node.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index f08e6208e183..2aef0632f35b 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -372,7 +372,9 @@ static int f2fs_do_sync_file(struct file *file, loff_t start, loff_t end, f2fs_remove_ino_entry(sbi, ino, APPEND_INO); clear_inode_flag(inode, FI_APPEND_WRITE); flush_out: - if (!atomic && F2FS_OPTION(sbi).fsync_mode != FSYNC_MODE_NOBARRIER) + if ((!atomic && F2FS_OPTION(sbi).fsync_mode != FSYNC_MODE_NOBARRIER) || + (atomic && !test_opt(sbi, NOBARRIER) && + f2fs_sb_has_blkzoned(sbi))) ret = f2fs_issue_flush(sbi, inode->i_ino); if (!ret) { f2fs_remove_ino_entry(sbi, ino, UPDATE_INO); diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index c280f482c741..7224a980056f 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1633,7 +1633,7 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted, goto redirty_out; } - if (atomic && !test_opt(sbi, NOBARRIER)) + if (atomic && !test_opt(sbi, NOBARRIER) && !f2fs_sb_has_blkzoned(sbi)) fio.op_flags |= REQ_PREFLUSH | REQ_FUA; /* should add to global list before clearing PAGECACHE status */ -- 2.36.0.rc0.470.gd361397f0d-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel