From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 649CDC433F5 for ; Thu, 12 May 2022 08:21:39 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1np44m-0007ip-PT; Thu, 12 May 2022 08:21:37 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1np44k-0007iR-Ty for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 May 2022 08:21:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MWRWnGZfnuGx8YuMPgaH7upWViR/u+JeIOMpGiLi7HE=; b=gZRrI5coVjV9ovePDyTh04q/ct o/xnQzbRjTu+ArkL4zTXrYGVZAifJLH9dB6gSlDZDWRxcwp+QfwGLZHLoOFCohg6dZRfYTlFY4cZy OEoFguS/uTxx1iX0NLRyNMRaHBx4dOyM9qNZvI9iHEt4/D3jrc+kIGkpCetfZjMtEKYk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=MWRWnGZfnuGx8YuMPgaH7upWViR/u+JeIOMpGiLi7HE=; b=W BzUOLOJjzf1ErLYeKz3jtcyEM72Fq4E8/aVKSvU8BhYmpXqOsE+FdoMVX+Ogz2SVh1wCO3CBdvnx6 Z9uz1UlqeDC6j2Ez9IEq6Egn2xdx4xKiQ97ieDRuq4TRMRImDfv5rfK16UpOhCPUzOqHiQ+k6EjCZ PYILe38ezwGnJSlc=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1np44k-009Xkg-8f for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 May 2022 08:21:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C108161F25; Thu, 12 May 2022 08:21:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88574C34100; Thu, 12 May 2022 08:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652343684; bh=LDuxo0C/j3JuilvCVq9g1dgYPVnODmnuaK6uUmG5w1Y=; h=From:To:Cc:Subject:Date:From; b=f+ogQxCHH3bdUp5bz/e462d+PUtXMQ3likb+EijEc9xeC8kgEH4R5YxnB/TH6E1tH C5HOTjnW5hzTSBIRHw22Hc9FPzpToGVs1BPc4iZvfkrRnRK4ygVzfuIJPfnXhKBwfN IRL4bkRhM49D72iH2W8U8aJBdVpbTMG67wBYjQzLH+mI5Z/6+av/EQY/DHSLqs+f4M 5cZeZFKlvT/T8OyG2d/V0eYsFlcZ7N5dqrVnEzHLp6wYkylS8evSCGuPeNI7GaTb7G McA1FQOUh/tA1myBooo0uB5PZN69RhCFTbOgdMdgIp3/Ol/8GxTHOSl9OADqQg/ENA wKtne9jffTS7w== From: Chao Yu To: jaegeuk@kernel.org Date: Thu, 12 May 2022 16:21:16 +0800 Message-Id: <20220512082116.2991611-1-chao@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Headers-End: 1np44k-009Xkg-8f Subject: [f2fs-dev] [PATCH] f2fs: separate NOCoW and pinfile semantics X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Pinning a file is heavy, because skipping pinned files make GC running with heavy load or no effect. So that this patch proposes to separate nocow and pinfile semantics: - NOCoW flag can only be set on regular file. - NOCoW file will only trigger IPU at common writeback/flush. - NOCow file will do OPU during GC. This flag can satisfying the demand of: 1) avoiding fragment of file's physical block 2) userspace doesn't want to pin file's physical address Signed-off-by: Chao Yu --- fs/f2fs/data.c | 3 ++- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 25 ++++++++++++++++++++++++- 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 54a7a8ad994d..c8eab78f7d89 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2495,7 +2495,8 @@ bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) if (is_inode_flag_set(inode, FI_ALIGNED_WRITE)) return false; - if (f2fs_is_pinned_file(inode)) + if (f2fs_is_pinned_file(inode) || + F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) return true; /* if this is cold file, we should overwrite to avoid fragmentation */ diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 492af5b96de1..e91ece55f5e8 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2916,6 +2916,7 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) #define F2FS_NOCOMP_FL 0x00000400 /* Don't compress */ #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ #define F2FS_CASEFOLD_FL 0x40000000 /* Casefolded file */ diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 09287876dbb7..7f92a3a157f7 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1851,6 +1851,20 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) if (IS_NOQUOTA(inode)) return -EPERM; + if ((iflags ^ masked_flags) & F2FS_NOCOW_FL) { + int ret; + + if (!S_ISREG(inode->i_mode)) + return -EINVAL; + if (f2fs_should_update_outplace(inode, NULL)) + return -EINVAL; + if (f2fs_is_pinned_file(inode)) + return -EINVAL; + ret = f2fs_convert_inline_inode(inode); + if (ret) + return ret; + } + if ((iflags ^ masked_flags) & F2FS_CASEFOLD_FL) { if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) return -EOPNOTSUPP; @@ -1926,6 +1940,7 @@ static const struct { { F2FS_NOCOMP_FL, FS_NOCOMP_FL }, { F2FS_INDEX_FL, FS_INDEX_FL }, { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, + { F2FS_NOCOW_FL, FS_NOCOW_FL }, { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, { F2FS_CASEFOLD_FL, FS_CASEFOLD_FL }, }; @@ -1957,7 +1972,8 @@ static const struct { FS_NOCOMP_FL | \ FS_DIRSYNC_FL | \ FS_PROJINHERIT_FL | \ - FS_CASEFOLD_FL) + FS_CASEFOLD_FL | \ + FS_NOCOW_FL) /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ static inline u32 f2fs_iflags_to_fsflags(u32 iflags) @@ -3081,6 +3097,13 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg) inode_lock(inode); + if (F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) { + f2fs_info(F2FS_I_SB(inode), "inode (%lu) is already NOCOW one", + inode->i_ino); + ret = -EINVAL; + goto out; + } + if (!pin) { clear_inode_flag(inode, FI_PIN_FILE); f2fs_i_gc_failures_write(inode, 0); -- 2.25.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel