From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [f2fs-dev] [PATCH 3/3] f2fs: do not skip updating inode when retrying to flush node page
Date: Fri, 17 Jun 2022 15:31:06 -0700 [thread overview]
Message-ID: <20220617223106.3517374-3-jaegeuk@kernel.org> (raw)
In-Reply-To: <20220617223106.3517374-1-jaegeuk@kernel.org>
Let's try to flush dirty inode again to improve subtle i_blocks mismatch.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/node.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 836c79a20afc..4181d03a7ef7 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1943,7 +1943,6 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
for (i = 0; i < nr_pages; i++) {
struct page *page = pvec.pages[i];
bool submitted = false;
- bool may_dirty = true;
/* give a priority to WB_SYNC threads */
if (atomic_read(&sbi->wb_sync_req[NODE]) &&
@@ -1996,11 +1995,8 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
}
/* flush dirty inode */
- if (IS_INODE(page) && may_dirty) {
- may_dirty = false;
- if (flush_dirty_inode(page))
- goto lock_node;
- }
+ if (IS_INODE(page) && flush_dirty_inode(page))
+ goto lock_node;
write_node:
f2fs_wait_on_page_writeback(page, NODE, true, true);
--
2.36.1.476.g0c4daa206d-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-06-17 22:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 22:31 [f2fs-dev] [PATCH 1/3] f2fs: attach inline_data after setting compression Jaegeuk Kim
2022-06-17 22:31 ` [f2fs-dev] [PATCH 2/3] f2fs: run GCs synchronously given user requests Jaegeuk Kim
2022-06-19 0:41 ` Chao Yu
2022-06-19 22:34 ` Jaegeuk Kim
2022-06-22 14:02 ` Chao Yu
2022-06-22 16:58 ` Jaegeuk Kim
2022-06-28 7:59 ` Chao Yu
2022-06-28 18:17 ` Jaegeuk Kim
2022-06-29 16:30 ` Jaegeuk Kim
2022-06-17 22:31 ` Jaegeuk Kim [this message]
2022-06-19 0:54 ` [f2fs-dev] [PATCH 3/3] f2fs: do not skip updating inode when retrying to flush node page Chao Yu
2022-06-19 0:35 ` [f2fs-dev] [PATCH 1/3] f2fs: attach inline_data after setting compression Chao Yu
2022-06-22 14:06 ` Chao Yu
2022-06-22 16:52 ` Jaegeuk Kim
2022-06-22 16:53 ` [f2fs-dev] [PATCH 1/3 v2] " Jaegeuk Kim
2022-06-28 7:46 ` Chao Yu
2022-06-28 7:50 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617223106.3517374-3-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).