From: Guowei Du <duguoweisz@gmail.com>
To: jaegeuk@kernel.org, chao@kernel.org
Cc: linux-kernel@vger.kernel.org, duguowei <duguowei@xiaomi.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH 7/7] f2fs: optimize shrink count
Date: Thu, 30 Jun 2022 19:26:29 +0800 [thread overview]
Message-ID: <20220630112629.6611-1-duguoweisz@gmail.com> (raw)
From: duguowei <duguowei@xiaomi.com>
Remove the local variable 'run_no', add comments for better
reading.
Signed-off-by: duguowei <duguowei@xiaomi.com>
---
fs/f2fs/shrinker.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/shrinker.c b/fs/f2fs/shrinker.c
index dd3c3c7a90ec..7e439496dfca 100644
--- a/fs/f2fs/shrinker.c
+++ b/fs/f2fs/shrinker.c
@@ -76,18 +76,18 @@ unsigned long f2fs_shrink_scan(struct shrinker *shrink,
unsigned long nr = sc->nr_to_scan;
struct f2fs_sb_info *sbi;
struct list_head *p;
- unsigned int run_no;
unsigned long freed = 0;
spin_lock(&f2fs_list_lock);
- do {
- run_no = ++shrinker_run_no;
- } while (run_no == 0);
+ shrinker_run_no++;
+ /* if overflow, next loop needs to skip number 0 */
+ if (!shrinker_run_no)
+ shrinker_run_no = 1;
p = f2fs_list.next;
while (p != &f2fs_list) {
sbi = list_entry(p, struct f2fs_sb_info, s_list);
- if (sbi->shrinker_run_no == run_no)
+ if (sbi->shrinker_run_no == shrinker_run_no)
break;
/* stop f2fs_put_super */
@@ -97,7 +97,7 @@ unsigned long f2fs_shrink_scan(struct shrinker *shrink,
}
spin_unlock(&f2fs_list_lock);
- sbi->shrinker_run_no = run_no;
+ sbi->shrinker_run_no = shrinker_run_no;
/* shrink extent cache entries */
freed += f2fs_shrink_extent_tree(sbi, nr >> 1);
--
2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2022-06-30 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:26 Guowei Du [this message]
2022-07-01 0:50 ` [f2fs-dev] [PATCH 7/7] f2fs: optimize shrink count Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630112629.6611-1-duguoweisz@gmail.com \
--to=duguoweisz@gmail.com \
--cc=chao@kernel.org \
--cc=duguowei@xiaomi.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).