From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E9A8C2BB9D for ; Sun, 14 Aug 2022 16:29:58 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oNGUv-0001Ht-TO; Sun, 14 Aug 2022 16:29:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oNGUu-0001Hj-U3 for linux-f2fs-devel@lists.sourceforge.net; Sun, 14 Aug 2022 16:29:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=O3FO1eb5XPOS7NluvrGvZKZeViJDVosrfhQ9URAh3BI=; b=b2kuljHWkHz2mg83ExB5j10tQk ijH3kj9g92MtoTjFrg213pQjms6uLebOxi3r69UUUkdY9VBAOPqUVJZq+v34lvzKY+zQMFEOYSjPv 3n7qD1IInXTMR3DXSM04EP2DufqXaje8LDSSLYw7wnRpT9TNXSvo46pLY1AZuwTbxLkg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=O3FO1eb5XPOS7NluvrGvZKZeViJDVosrfhQ9URAh3BI=; b=OZ7psBpvqqXDPWqg2/OqVIPjKg DtIAu3EG1fwt/4tG77gujllLvV49Zb0XK3uAXy/JFFzfLCbs2qefaeYYW0HMGZXdxYg4zDsLcQTJj jFzQaites8xKBZg4K5BhMpyosx1qihKXQ0zxogK/NS2uNk+tQ9VjKQ44CEqlLn/1Jvho=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oNGUu-0029Wd-3A for linux-f2fs-devel@lists.sourceforge.net; Sun, 14 Aug 2022 16:29:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D0822B80B3C; Sun, 14 Aug 2022 16:29:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B774C433B5; Sun, 14 Aug 2022 16:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660494588; bh=KLIBEcsh5152wFckpsV3ZF+ehgzB/McM0dh95FMn3KU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G6mHnhNCYcLmln9LwsCaDiDGPmgsdNwXtBepD3qH/hNWeMQBB1fT3r6LnoD6TjWxq P1foSmZNg43qKcM6Dd1F9iTeW8ibvEiRBRZdFwBnBsOjsOuXoWxM1mgFYeOK1y9iyA 6Es/asKp2GG73MscM330zHQFI+m2GiK8Jr1qdqP8OSIONmiztEOJARS6uCqbn/d0Fy 5JlvIRb4j+UQIJVzU8jW5SGJuWonw5EpVDo7rJ7QBdi50NSHycogGkH83SP+eHHGPo VUwlLG+OebILJnWZfAZrWpgNCcH9okKnbndOrUnDgzP+LsIfWhpGqKz8nzXN7QrxUB JerxdFc9muUQg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Sun, 14 Aug 2022 12:29:16 -0400 Message-Id: <20220814162922.2398723-10-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220814162922.2398723-1-sashal@kernel.org> References: <20220814162922.2398723-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-Headers-End: 1oNGUu-0029Wd-3A Subject: [f2fs-dev] [PATCH AUTOSEL 4.19 10/14] f2fs: fix to avoid use f2fs_bug_on() in f2fs_new_node_page() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-f2fs-devel@lists.sourceforge.net, Dipanjan Das , Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Chao Yu [ Upstream commit 141170b759e03958f296033bb7001be62d1d363b ] As Dipanjan Das reported, syzkaller found a f2fs bug as below: RIP: 0010:f2fs_new_node_page+0x19ac/0x1fc0 fs/f2fs/node.c:1295 Call Trace: write_all_xattrs fs/f2fs/xattr.c:487 [inline] __f2fs_setxattr+0xe76/0x2e10 fs/f2fs/xattr.c:743 f2fs_setxattr+0x233/0xab0 fs/f2fs/xattr.c:790 f2fs_xattr_generic_set+0x133/0x170 fs/f2fs/xattr.c:86 __vfs_setxattr+0x115/0x180 fs/xattr.c:182 __vfs_setxattr_noperm+0x125/0x5f0 fs/xattr.c:216 __vfs_setxattr_locked+0x1cf/0x260 fs/xattr.c:277 vfs_setxattr+0x13f/0x330 fs/xattr.c:303 setxattr+0x146/0x160 fs/xattr.c:611 path_setxattr+0x1a7/0x1d0 fs/xattr.c:630 __do_sys_lsetxattr fs/xattr.c:653 [inline] __se_sys_lsetxattr fs/xattr.c:649 [inline] __x64_sys_lsetxattr+0xbd/0x150 fs/xattr.c:649 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x46/0xb0 NAT entry and nat bitmap can be inconsistent, e.g. one nid is free in nat bitmap, and blkaddr in its NAT entry is not NULL_ADDR, it may trigger BUG_ON() in f2fs_new_node_page(), fix it. Reported-by: Dipanjan Das Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/node.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index ff3f97ba1a55..2c28f488ac2f 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1232,7 +1232,11 @@ struct page *f2fs_new_node_page(struct dnode_of_data *dn, unsigned int ofs) dec_valid_node_count(sbi, dn->inode, !ofs); goto fail; } - f2fs_bug_on(sbi, new_ni.blk_addr != NULL_ADDR); + if (unlikely(new_ni.blk_addr != NULL_ADDR)) { + err = -EFSCORRUPTED; + set_sbi_flag(sbi, SBI_NEED_FSCK); + goto fail; + } #endif new_ni.nid = dn->nid; new_ni.ino = dn->inode->i_ino; -- 2.35.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel