From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9175BC05027 for ; Mon, 6 Feb 2023 03:43:58 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pOsQA-0002Rl-Lo; Mon, 06 Feb 2023 03:43:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pOsQ8-0002Re-CK for linux-f2fs-devel@lists.sourceforge.net; Mon, 06 Feb 2023 03:43:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1r8PjiwnqtuQNMQh0gxDa7lBaq3XTaLCInGTVvvV5IU=; b=OiFQRqdQp+f8r+Lil4jBifrA6w 7NJ7483KecHhdgEUd4MEd5bvycU2GLf7PfDXianOTUb4D4CW1XszJO5ySiuAyO3kSVL8k7vKb2OFe SA1g3H+P0ylmc6wnU1dMacydLy5eiR4BblPEYBVZh8GrvXDZLe6ECtV4XAZSKxrOg9DE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=1r8PjiwnqtuQNMQh0gxDa7lBaq3XTaLCInGTVvvV5IU=; b=Y 05kWxfzytpGQhYTZHQo0q5CHKfu39wBJpfxv2l9XgiWlEcGm4dXb8aHGN9vJ1T7gnBibLypWQYBL2 0ZD6WKOKS0jJzU8FbhfgX8V0Mgd9whS5WE9vwm7/1IwEPEOP3l89u9Jd+S3qdeDbrj6k6nLcyB7LU c4pXtusTZ44bdOqA=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pOsQ6-0005hm-1l for linux-f2fs-devel@lists.sourceforge.net; Mon, 06 Feb 2023 03:43:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8C4C1B80906 for ; Mon, 6 Feb 2023 03:43:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28F54C433EF; Mon, 6 Feb 2023 03:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675655027; bh=I6XJ1YYl5GhAsWCjBFGIoN3YE0rbCKgyl8VhuEMuFvI=; h=From:To:Cc:Subject:Date:From; b=PouiTb7sHTX8feMHRonqeyUnuKRbiu6PSrAtYhpbrz2sPg3lngHUQQgRKGAOmYg6u MucWH1lBavZTEh6cWYltL2uk2eL/N/XFTa9RoDmHY3CRqefsNbDj27q5jKTBzj58UM QZcsjJA0g6SQBikBKmtdiGBfYVxISa6kmdgAl6P9BdOv3/6w49iZY03NV8L1y6TC9q 0/CwMJCx2h8ss9+S0oycq0ihQ8RP1CvyLOHpuicr8iySmXoVJMXza4wcu/MVFAW/S4 B49EB59s7ZwkHC5TmKhEMba5Ri+yBp2rltygOIUvmaR+fLoiLddGujaeS/u2RQSN0p WPcuiRd1qEvVg== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Sun, 5 Feb 2023 19:43:44 -0800 Message-Id: <20230206034344.724593-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.39.1.519.gcb327c4b5f-goog MIME-Version: 1.0 X-Headers-End: 1pOsQ6-0005hm-1l Subject: [f2fs-dev] [PATCH] f2fs: fix kernel crash due to null io->bio X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net We should return when io->bio is null before doing anything. Otherwise, panic. BUG: kernel NULL pointer dereference, address: 0000000000000010 RIP: 0010:__submit_merged_write_cond+0x164/0x240 [f2fs] Call Trace: f2fs_submit_merged_write+0x1d/0x30 [f2fs] commit_checkpoint+0x110/0x1e0 [f2fs] f2fs_write_checkpoint+0x9f7/0xf00 [f2fs] ? __pfx_issue_checkpoint_thread+0x10/0x10 [f2fs] __checkpoint_and_complete_reqs+0x84/0x190 [f2fs] ? preempt_count_add+0x82/0xc0 ? __pfx_issue_checkpoint_thread+0x10/0x10 [f2fs] issue_checkpoint_thread+0x4c/0xf0 [f2fs] ? __pfx_autoremove_wake_function+0x10/0x10 kthread+0xff/0x130 ? __pfx_kthread+0x10/0x10 ret_from_fork+0x2c/0x50 Cc: stable@vger.kernel.org # v5.18+ Fixes: 64bf0eef0171 ("f2fs: pass the bio operation to bio_alloc_bioset") Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 12f233f2fd58..ea8311a58ab7 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -653,6 +653,9 @@ static void __f2fs_submit_merged_write(struct f2fs_sb_info *sbi, f2fs_down_write(&io->io_rwsem); + if (!io->bio) + goto unlock_out; + /* change META to META_FLUSH in the checkpoint procedure */ if (type >= META_FLUSH) { io->fio.type = META_FLUSH; @@ -661,6 +664,7 @@ static void __f2fs_submit_merged_write(struct f2fs_sb_info *sbi, io->bio->bi_opf |= REQ_PREFLUSH | REQ_FUA; } __submit_merged_bio(io); +unlock_out: f2fs_up_write(&io->io_rwsem); } -- 2.39.1.519.gcb327c4b5f-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel