From: Eric Biggers <ebiggers@kernel.org>
To: Sheng Yong <shengyong@oppo.com>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: add f2fs_ioc_[get|set]_extra_attr
Date: Wed, 31 May 2023 20:16:58 -0700 [thread overview]
Message-ID: <20230601031658.GA728@quark.localdomain> (raw)
In-Reply-To: <20230529013502.2230810-1-shengyong@oppo.com>
On Mon, May 29, 2023 at 09:35:00AM +0800, Sheng Yong via Linux-f2fs-devel wrote:
> This patch introduces two ioctls:
> * f2fs_ioc_get_extra_attr
> * f2fs_ioc_set_extra_attr
> to get or modify values in extra attribute area.
>
> The argument of these two ioctls is `struct f2fs_extra_attr', which has
> three members:
> * field: indicates which field in extra attribute area is handled
> * attr: value or userspace pointer
> * attr_size: size of `attr'
>
> The `field' member could help extend functionality of these two ioctls
> without modify or add new interfaces, if more fields are added into
> extra attributes ares in the feture.
>
> Signed-off-by: Sheng Yong <shengyong@oppo.com>
Aren't there enough things called extra or extended attributes already? Besides
the standard "extended attributes" retrievable with the getxattr() system call,
there is already the FS_IOC_FSGETXATTR ioctl too.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-06-01 3:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 1:35 [f2fs-dev] [PATCH] f2fs: add f2fs_ioc_[get|set]_extra_attr Sheng Yong via Linux-f2fs-devel
2023-05-29 1:35 ` [f2fs-dev] [PATCH 1/2] f2fs_io: add [get|set_attr] to access inode extra attributes Sheng Yong via Linux-f2fs-devel
2023-06-01 3:13 ` Chao Yu
2023-06-04 3:56 ` [f2fs-dev] [PATCH v2 " Sheng Yong via Linux-f2fs-devel
2023-06-04 3:56 ` [f2fs-dev] [PATCH v2 2/2] f2fs_io: convert compression ioctls to [get|set]_attr Sheng Yong via Linux-f2fs-devel
2023-05-29 1:35 ` [f2fs-dev] [PATCH " Sheng Yong via Linux-f2fs-devel
2023-05-29 6:10 ` [f2fs-dev] [PATCH] f2fs: add f2fs_ioc_[get|set]_extra_attr kernel test robot
2023-05-29 6:20 ` kernel test robot
2023-05-29 8:19 ` kernel test robot
2023-05-30 6:34 ` [f2fs-dev] [PATCH v2] " Sheng Yong via Linux-f2fs-devel
2023-06-01 3:06 ` Chao Yu
2023-06-04 2:28 ` [f2fs-dev] [PATCH v3] " Sheng Yong via Linux-f2fs-devel
2023-06-07 17:09 ` Jaegeuk Kim
2023-06-01 3:16 ` Eric Biggers [this message]
2023-06-01 14:37 ` [f2fs-dev] [PATCH] " Sheng Yong via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601031658.GA728@quark.localdomain \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shengyong@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).