[f2fs-dev] [PATCH] dump.f2fs: remove redundant check condition in dump_node()

[f2fs-dev] [PATCH] dump.f2fs: remove redundant check condition in dump_node()

[Chao Yu]

In dump_node(), f2fs_is_valid_blkaddr() has checked ni.blk_addr's
validity and dump_node() will bail up if ni.blk_addr is invalid,
so let's remove redundant check condition and print below:

	if (ni.blk_addr == 0x0)
		MSG(force, "Invalid nat entry\n\n");

Signed-off-by: Chao Yu <chao@kernel.org>
---
 fsck/dump.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fsck/dump.c b/fsck/dump.c
index 6c1857f..e7a1c5c 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -605,9 +605,7 @@ int dump_node(struct f2fs_sb_info *sbi, nid_t nid, int force)
 
 	dev_read_block(node_blk, ni.blk_addr);
 
-	if (ni.blk_addr == 0x0)
-		MSG(force, "Invalid nat entry\n\n");
-	else if (!is_sit_bitmap_set(sbi, ni.blk_addr))
+	if (!is_sit_bitmap_set(sbi, ni.blk_addr))
 		MSG(force, "Invalid sit bitmap, %u\n\n", ni.blk_addr);
 
 	DBG(1, "node_blk.footer.ino [0x%x]\n", le32_to_cpu(node_blk->footer.ino));
-- 
2.40.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel