From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DDC8C0015E for ; Sat, 29 Jul 2023 04:18:32 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qPbPS-00034W-0k; Sat, 29 Jul 2023 04:18:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qPbPQ-00034Q-Qo for linux-f2fs-devel@lists.sourceforge.net; Sat, 29 Jul 2023 04:18:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W2Cm8TVs+K/RD3BiTajPfIBZkK47gghPIcLMMX97VHg=; b=Z8jdMOtxvSha2iTU1nh6Fstv+T uOtKyUL3IVwOzebwpMNZwXI54SFsKk+9OQFwhmuhLgyfjWswblX3prNUE0B/sVBtxSj2jREnsVY18 o5fZ1LJ/JwW9ILAH2XdyBLqF8QaVeQigQy3RVcxFDDXIxypvqvsDIdZQvnDCjcAOYeSk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W2Cm8TVs+K/RD3BiTajPfIBZkK47gghPIcLMMX97VHg=; b=AET+EfyqUchvr7UP5POEDdbGDM 64baZIEYL8S7NNwCdtnlubGrdACp5J5msjY7dOH0pH1+1/dVDNZr5P+T7KMNu/X3A1uq+blSSLXc5 rIMl9Sf0mlkL6ssZbxURahlpaBZThW3VBOC04T+jQCkvOXCHQgvv7NABxkqBwSUWyYzQ=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qPbPK-0005NC-BG for linux-f2fs-devel@lists.sourceforge.net; Sat, 29 Jul 2023 04:18:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D905660A5D; Sat, 29 Jul 2023 04:18:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7580C433C7; Sat, 29 Jul 2023 04:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690604291; bh=KQBZTd1S0knxsGiSweS0mSJsa3IrgD8+KiGKrRwjDpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HzTepYHLCqjPnb04DG+lQ/wa+C7QCxmCzeepM4xWu7HFaFHnXwaqMArNTKsLWVTDf clYhanByTkW5HO+MBCicjRqObbYeuiIDjXz8nOWyUKhHhrUcEk0vmDjU3T/8QIpJAx FyFhIzFZzkaIpE1BKfAxqTOlzvdy3duJSmOf0DfIftTBjp6uMCBn1g28waTGOR0ffz X439aHHgq0bDLUjyA4+8Y/+cmbZzdZ/U4KUoDvz00xMswfnK64x16BHt+hVtjeg3uK y08JiKTf+0ZH2gfo/tLny4Wl41AU8Y5O5qiofOu0sY4U9tJ32b/F9+3oXNKHoj4Fdu 7zqOMC5HzOIjw== Date: Fri, 28 Jul 2023 21:18:09 -0700 From: Eric Biggers To: Gabriel Krisman Bertazi Message-ID: <20230729041809.GA4171@sol.localdomain> References: <20230727172843.20542-1-krisman@suse.de> <20230727172843.20542-4-krisman@suse.de> <20230728-beckenrand-wahrlich-62d6b0505d68@brauner> <87r0os139h.fsf@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87r0os139h.fsf@suse.de> X-Headers-End: 1qPbPK-0005NC-BG Subject: Re: [f2fs-dev] [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Brauner , tytso@mit.edu, linux-f2fs-devel@lists.sourceforge.net, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Jul 28, 2023 at 11:09:46AM -0400, Gabriel Krisman Bertazi wrote: > Christian Brauner writes: > > > On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote: > > > > > Wouldn't it make sense to get rid of all this indentation? > > I'm ok with making this change. I'll wait for more reviews and Eric > before sending a new version with this done. > > Thanks! > Well, the issue is that with patch 4, all the 'return 1;' would need to change to 'return fscrypt_d_revalidate(dentry, flags);'. A helper function could be used, though, if you prefer: static int generic_ci_d_revalidate(struct dentry *dentry, const struct qstr *name, unsigned int flags) { if (!ci_d_revalidate(dentry, name, flags)) return 0; return fscrypt_d_revalidate(dentry, flags); } - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel