From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E43C1C001E0 for ; Wed, 9 Aug 2023 07:04:41 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qTdFH-0003Yy-62; Wed, 09 Aug 2023 07:04:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qTdFG-0003Yr-Jb for linux-f2fs-devel@lists.sourceforge.net; Wed, 09 Aug 2023 07:04:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DH4ItoPl4t9BDzY4p84Kc5DS/kvp/4jxDQStke3yeoI=; b=F2VB/WQpb+2mnXW9wlgdGXCxpl 8STqh0jQcb6jo77eyhHe513ltsbPbRGvm3gNEZE6fShwTaNujHrIeYRN0qxr+Wqkw6ySM1tDcgc18 9Mjw0lymMsl9Nl//q6ScOH3fDc8k/gS/Nu4/YOlEi1wWZca5NMSknFX6p2MNtGDZnI6A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DH4ItoPl4t9BDzY4p84Kc5DS/kvp/4jxDQStke3yeoI=; b=AjGaibWbcatB6EraUYA8BaoB7G XBQirNaibU2c4kRGxXK81TrYytKK1OqczJEVNERGaa6Yt5eWlM4zZjsYNeBn8Z7FoCHT3kg+1GBdu GorKp7UQtcONIIHBBoPM4VVMPceKybP5xljk64Yq7ik9Ako0/VxRl8gNZHCjNG5ZEOQ0=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qTdFE-00024D-RF for linux-f2fs-devel@lists.sourceforge.net; Wed, 09 Aug 2023 07:04:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 012D462FB3; Wed, 9 Aug 2023 07:04:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF415C433C8; Wed, 9 Aug 2023 07:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691564670; bh=mNaI4yIhrZSJhUwcMni6JCN62HgxRgb2ToogP2H4jFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dm1BfYtz2dqQMxa4y4K1DetMu3X3Ln+bwz+2jEemWCBc68DqnWDXfI9TyuC86JRyc OV6+7i/vF54n6ROMNvy+VNt+3Tcbr5mPPxWG7+kZZzvdk1l5Y2fXqdyi4kiTIEHp6R c+NokRM5ch22ngFHcUfi3IxiA2Hed3py0L00cGbjgid38+MsphBbYkHDRv8n5kfv6l 165HU85tqTN8dPjx7l1xQ1d3Tv6OZoFdRY/kHWh7X900UpXqc/s3kp4a/FPaL7/Rze xRv3G8HkDEWg3uieFtEQ8pvVu174WnaDQBFW7zKSqu+mNZR7+LKPBNsWLcV/CsHS/4 sOc78sTonZdgw== Date: Wed, 9 Aug 2023 09:04:12 +0200 From: Christian Brauner To: Jan Kara Message-ID: <20230809-abartig-lachen-df1965c6b37a@brauner> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-7-d1dec143a704@kernel.org> <20230808093903.2cg5wwbwbvflkeph@quack3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230808093903.2cg5wwbwbvflkeph@quack3> X-Headers-End: 1qTdFE-00024D-RF Subject: Re: [f2fs-dev] [PATCH v7 07/13] xfs: have xfs_vn_update_time gets its own timestamp X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Martin Brandenburg , Konstantin Komarov , linux-xfs@vger.kernel.org, "Darrick J. Wong" , Dominique Martinet , Christian Schoenebeck , ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, David Howells , Chris Mason , Andreas Dilger , Hans de Goede , Marc Dionne , samba-technical@lists.samba.org, codalist@coda.cs.cmu.edu, linux-afs@lists.infradead.org, linux-mtd@lists.infradead.org, Mike Marshall , Paulo Alcantara , linux-cifs@vger.kernel.org, Eric Van Hensbergen , Andreas Gruenbacher , Miklos Szeredi , Richard Weinberger , Mark Fasheh , Hugh Dickins , Benjamin Coddington , Tyler Hicks , cluster-devel@redhat.com, coda@cs.cmu.edu, linux-mm@kvack.org, Ilya Dryomov , Iurii Zaikin , Namjae Jeon , Trond Myklebust , Shyam Prasad N , Amir Goldstein , Kees Cook , ocfs2-devel@lists.linux.dev, Josef Bacik , Tom Talpey , Tejun Heo , Yue Hu , Alexander Viro , Ronnie Sahlberg , David Sterba , Jaegeuk Kim , ceph-devel@vger.kernel.org, Xiubo Li , Gao Xiang , OGAWA Hirofumi , Jan Harkes , linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, Theodore Ts'o , Joseph Qi , Greg Kroah-Hartman , v9fs@lists.linux.dev, ntfs3@lists.linux.dev, Jeff Layton , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Steve French , Sergey Senozhatsky , Luis Chamberlain , Jeffle Xu , devel@lists.orangefs.org, Anna Schumaker , Jan Kara , Bob Peterson , linux-fsdevel@vger.kernel.org, Andrew Morton , Sungjong Seo , linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org, Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Aug 08, 2023 at 11:39:03AM +0200, Jan Kara wrote: > On Mon 07-08-23 15:38:38, Jeff Layton wrote: > > In later patches we're going to drop the "now" parameter from the > > update_time operation. Prepare XFS for this by reworking how it fetches > > timestamps and sets them in the inode. Ensure that we update the ctime > > even if only S_MTIME is set. > > > > Signed-off-by: Jeff Layton > > --- > > fs/xfs/xfs_iops.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > > index 731f45391baa..72d18e7840f5 100644 > > --- a/fs/xfs/xfs_iops.c > > +++ b/fs/xfs/xfs_iops.c > > @@ -1037,6 +1037,7 @@ xfs_vn_update_time( > > int log_flags = XFS_ILOG_TIMESTAMP; > > struct xfs_trans *tp; > > int error; > > + struct timespec64 now = current_time(inode); > > No need to fetch current_time() here where you overwrite it just a bit > later... It also shadows the @now parameter of that function. Since that function parameter is dropped in follow-up patches I simply s/now/time/g it here. In any case, fixed in-tree. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel