From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] circular locking dependency warning in f2fs
Date: Thu, 17 Aug 2023 08:53:19 -0700 [thread overview]
Message-ID: <20230817155319.GA1483@sol.localdomain> (raw)
In-Reply-To: <63722b9f-b510-50a7-8839-6ada783d2164@kernel.org>
On Thu, Aug 17, 2023 at 10:26:12PM +0800, Chao Yu wrote:
> > > > lock(new_inode#2->i_sem)
> > > > lock(dir->i_xattr_sem)
> > > > lock(new_inode#1->i_sem)
> > > >
> > > > This looks fine to me.
> > > >
> > >
> > > Based on your feedback, am I correct assuming that you don't plan
> > > to fix this ?
> >
> > I'm quite open to something that I may miss. Chao, what do you think?
>
> Jaegeuk, I agree with you, it looks like a false alarm.
>
False positive lockdep reports still need to be eliminated, for example by
fixing the lockdep annotations. Otherwise it's impossible to distinguish them
from true positives.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-08-17 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 5:09 [f2fs-dev] circular locking dependency warning in f2fs Guenter Roeck
2023-08-16 17:25 ` Jaegeuk Kim
2023-08-17 2:11 ` Guenter Roeck
2023-08-17 3:52 ` Jaegeuk Kim
2023-08-17 5:22 ` Guenter Roeck
2023-08-17 14:26 ` Chao Yu
2023-08-17 15:53 ` Eric Biggers [this message]
2023-08-18 13:15 ` Guenter Roeck
2023-08-18 17:28 ` Jaegeuk Kim
2023-08-19 0:35 ` Jaegeuk Kim
2023-08-19 2:06 ` Guenter Roeck
2023-08-21 19:37 ` Jaegeuk Kim
2023-08-21 20:43 ` Guenter Roeck
2023-08-21 0:43 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817155319.GA1483@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).