From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4315BC83F12 for ; Mon, 28 Aug 2023 14:15:30 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qad1c-0003rx-PV; Mon, 28 Aug 2023 14:15:29 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qad1a-0003rq-BG for linux-f2fs-devel@lists.sourceforge.net; Mon, 28 Aug 2023 14:15:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3JYn7thNlmLQqnkScFAD85nPybgGPBVIx1IoTQc28Jc=; b=G8XEZVCrSAn1aksdqqhzjxiE10 nJLgqVUFfXF5EjykT6SDMr8GKFTovRcxR66svWjZS/kZA806h758PyiClwvTV9VBSwQqlx5U3rxWH EJnQTSlO9e6mvJSR0cRuyByfzIk2pa4HZhOF1uh0qIgXbl4yycLqwEQ+EJ0NSOq0wh0I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3JYn7thNlmLQqnkScFAD85nPybgGPBVIx1IoTQc28Jc=; b=NDMWoGLPIXAoNrABirXcVnj9yy 6GTubzkGjz4VJ0yp9HjfCTnQEgK90fW0N3SAZn6fkev2QSmLaIw4A8jo3p3az9J9T16jKOdlePRfj 9iswpVXITFznJwrEoX20cr/S6L93cawYu7puTgWRIFSwW/KI8LhWTJdNL8qNA6upMGbg=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qad1a-0004cd-CF for linux-f2fs-devel@lists.sourceforge.net; Mon, 28 Aug 2023 14:15:27 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 94DCE68C7B; Mon, 28 Aug 2023 16:15:13 +0200 (CEST) Date: Mon, 28 Aug 2023 16:15:12 +0200 From: Christoph Hellwig To: Al Viro Message-ID: <20230828141512.GA19883@lst.de> References: <20230601145904.1385409-1-hch@lst.de> <20230601145904.1385409-4-hch@lst.de> <20230827194122.GA325446@ZenIV> <20230827214518.GU3390869@ZenIV> <20230828123259.GB11084@lst.de> <20230828135615.GW3390869@ZenIV> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230828135615.GW3390869@ZenIV> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1qad1a-0004cd-CF Subject: Re: [f2fs-dev] [PATCH 03/12] filemap: update ki_pos in generic_perform_write X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Darrick J. Wong" , linux-mm@kvack.org, Christoph Hellwig , Andreas Gruenbacher , Miklos Szeredi , Matthew Wilcox , cluster-devel@redhat.com, Ilya Dryomov , linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-block@vger.kernel.org, Damien Le Moal , Hannes Reinecke , Jaegeuk Kim , ceph-devel@vger.kernel.org, Xiubo Li , Trond Myklebust , Jens Axboe , Christian Brauner , Theodore Ts'o , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Anna Schumaker , linux-fsdevel@vger.kernel.org, Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Aug 28, 2023 at 02:56:15PM +0100, Al Viro wrote: > The first failure exit does not need any work - the caller had not bumped > ->ki_pos; the second one (after that 'if (err < 0) {' line) does and that's > where the patch upthread adds iocb->ki_pos -= buffered_written. > > Or am I completely misparsing what you've written? No, I misread the patch. Looks good: Acked-by: Christoph Hellwig _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel