From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC598C00E86 for ; Wed, 20 Sep 2023 15:31:02 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qizAJ-0000Jy-AA; Wed, 20 Sep 2023 15:31:00 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qizA5-0000JT-4Y for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 Sep 2023 15:30:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=CvwijpZ/8LxG4TN9+GHQbJyHck IWtgjNYG6Ino2A2uSrYaHmC0stjZqdcQbAoX4/LVwW6yPR3dYEcp+TDTSrpMO858brQwxRf/o/VBE FeeuWvQv2yEGDi+bG3EqYQrweK2v7DT0IwwlG6L/4vowvlH5Yj0Zucl1sHD9iNjrZae4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=MAckLiX0w0NA137SWtOvVen62C OKf/MvydH3TW1Wziw5f/t2ALv7EratuVsQGbuyFLLdzajUDDvNsVoQinNIWBYGpJy90qS0KLY9eGf XZf9fK91lRLOcSqvJLUHww1xqI7dAD3wuIcMpU7+uh0nzJIN7PU0LGkSYvF8OQnx0DlM=; Received: from smtp-out1.suse.de ([195.135.220.28]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qizA3-00Gu3Z-KH for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 Sep 2023 15:30:44 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2A37D21F95; Wed, 20 Sep 2023 15:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1695223837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=cPiRr5NlB4Iwub7EwKz86boVSJQJZ3WLxzLaU6G09EfO4FmtVOdy7KUFneBvjrGmUR3ITh 2SAzepsqhIpBmvq/dM3lwFGS4jeZb1JiYpwLyM/YRSlBcScjreBuxS42wYeBxMo6k0JIzb vOOpZeXkJqjpWBWmAFVZOTXkw8HJ8lk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1695223837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=6KZkGGsMv2dh1rvGNnyToBfPP9oSwDD0PDv8XeIzbn7pcxdfbwlBblC3C43EGbanxkRyi5 mASfcKX9dgdX2bCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0DEDB132C7; Wed, 20 Sep 2023 15:30:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +bZeAx0QC2WLRwAAMHmgww (envelope-from ); Wed, 20 Sep 2023 15:30:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 97616A077D; Wed, 20 Sep 2023 17:30:36 +0200 (CEST) Date: Wed, 20 Sep 2023 17:30:36 +0200 From: Jan Kara To: Christian Brauner Message-ID: <20230920153036.pfg5h4aoed6ua6s3@quack3> References: <20230919110457.7fnmzo4nqsi43yqq@quack3> <1f29102c09c60661758c5376018eac43f774c462.camel@kernel.org> <4511209.uG2h0Jr0uP@nimes> <08b5c6fd3b08b87fa564bb562d89381dd4e05b6a.camel@kernel.org> <20230920-leerung-krokodil-52ec6cb44707@brauner> <20230920101731.ym6pahcvkl57guto@quack3> <317d84b1b909b6c6519a2406fcb302ce22dafa41.camel@kernel.org> <20230920-raser-teehaus-029cafd5a6e4@brauner> <57C103E1-1AD2-4D86-926C-481BC6BDB191@oracle.com> <20230920-keine-eile-c9755b5825db@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230920-keine-eile-c9755b5825db@brauner> X-Headers-End: 1qizA3-00Gu3Z-KH Subject: Re: [f2fs-dev] [PATCH v7 12/13] ext4: switch to multigrain timestamps X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Martin Brandenburg , Konstantin Komarov , Jan Kara , "linux-xfs@vger.kernel.org" , "Darrick J. Wong" , Dominique Martinet , Christian Schoenebeck , "linux-unionfs@vger.kernel.org" , David Howells , Chris Mason , Andreas Dilger , Hans de Goede , Marc Dionne , "samba-technical@lists.samba.org" , "codalist@coda.cs.cmu.edu" , "linux-afs@lists.infradead.org" , "linux-mtd@lists.infradead.org" , Mike Marshall , Paulo Alcantara , Amir Goldstein , Eric Van Hensbergen , "bug-gnulib@gnu.org" , Andreas Gruenbacher , Miklos Szeredi , Richard Weinberger , Mark Fasheh , Hugh Dickins , Benjamin Coddington , Tyler Hicks , "cluster-devel@redhat.com" , "coda@cs.cmu.edu" , "linux-mm@kvack.org" , Gao Xiang , Iurii Zaikin , Namjae Jeon , Trond Myklebust , Xi Ruoyao , Shyam Prasad N , "ecryptfs@vger.kernel.org" , Kees Cook , "ocfs2-devel@lists.linux.dev" , "linux-cifs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , Josef Bacik , Tom Talpey , Tejun Heo , Yue Hu , Al Viro , Ronnie Sahlberg , David Sterba , Jaegeuk Kim , "ceph-devel@vger.kernel.org" , Xiubo Li , Ilya Dryomov , OGAWA Hirofumi , Jan Harkes , Linux NFS Mailing List , "linux-ext4@vger.kernel.org" , Theodore Ts'o , Joseph Qi , Greg Kroah-Hartman , "v9fs@lists.linux.dev" , "ntfs3@lists.linux.dev" , Jeff Layton , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , Steve French , Sergey Senozhatsky , Luis Chamberlain , Chuck Lever III , Jeffle Xu , "devel@lists.orangefs.org" , Anna Schumaker , Jan Kara , Bo b Peterson , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Sungjong Seo , Bruno Haible , "linux-btrfs@vger.kernel.org" , Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed 20-09-23 16:53:26, Christian Brauner wrote: > > You could put it behind an EXPERIMENTAL Kconfig option so that the > > code stays in and can be used by the brave or foolish while it is > > still being refined. > > Given that the discussion has now fully gone back to the drawing board > and this is a regression the honest thing to do is to revert the five > patches that introduce the infrastructure: > > ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") > d48c33972916 ("tmpfs: add support for multigrain timestamps") > e44df2664746 ("xfs: switch to multigrain timestamps") > 0269b585868e ("ext4: switch to multigrain timestamps") > 50e9ceef1d4f ("btrfs: convert to multigrain timestamps") > > The conversion to helpers and cleanups are sane and should stay and can > be used for any solution that gets built on top of it. > > I'd appreciate a look at the branch here: > git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.ctime.revert > > survives xfstests. Agreed. I think most of ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") will be needed anyway but there's no problem in reintroducing it in the new solution. I've checked the branch and the reverts look good to me. Feel free to add: Acked-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel