From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 922B4C27C40 for ; Wed, 22 Nov 2023 21:19:16 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r5ucs-0004Oy-Oe; Wed, 22 Nov 2023 21:19:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r5ucs-0004Os-0D for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Nov 2023 21:19:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Sender:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GbGgxXd0D6P3kK6eEYEOVB7NqqPtigeykui8LfkWNZM=; b=lrOEHb2P5XyXMqo6nyYSjcBwuB PCEHLD2IhzTukLuSftbjugTSy5ZScFjkerKhgYZhQtG9xdGGb6pvAoxbwkUPZXjaobi1WGufA4Yol TjayldLwDlkbG01oTrMJk5WsoUmE0pFsSzHwMtsXPqBHkuWuoH6RlrOsNowZsTdm7BlY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GbGgxXd0D6P3kK6eEYEOVB7NqqPtigeykui8LfkWNZM=; b=IjC1IxAQ+ixcEXzVN5YJue7l04 j17eb/EEnFouxi2UqHELOaMb+kqpRFQPv7AL2Ow+EYGLNPo99xuPeAW1sT/HZdPa75lJwKu5Lk6YR ZGhAmVHQaF9zY7nZXYILbpZkk11rjwD/zFu8aIwVozT5wcSZXBvqqOWKEqi93+SmFia4=; Received: from zeniv.linux.org.uk ([62.89.141.173]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1r5ucq-0000km-ER for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Nov 2023 21:19:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GbGgxXd0D6P3kK6eEYEOVB7NqqPtigeykui8LfkWNZM=; b=mI/nBUzbuLRl8y71pGzGwG3AqE 9nwjsJ2gz+NhHF9XD6iYO4i+9WjMVuzBqAY16Wd/yrssV0AaFAv02ZkujqU5S78p8rOPo/SUuyk4W 8/nT5AO6eLxpRd56238mkk7z92XdfpSyf1N4qCYODg2gNDegCwfS36EIdJMnpzbyg7jIOIqlm60a2 cN+L44mlhZcn4bOy1TdDvE3F2HyesD2+3TOjf/yriqIuoujbwk+Nw4r8tfbC6bs0khIm3iyEeR0VO hr8fiUavTzkDlQHsYuue1vVtFUt9QBG1qUpXfi8yRo5l95o54GwvPikZo1kq4tHNgUWZHJcpxjlAn H3hu8bYw==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1r5ucf-001mtu-1r; Wed, 22 Nov 2023 21:19:01 +0000 Date: Wed, 22 Nov 2023 21:19:01 +0000 From: Al Viro To: Linus Torvalds Message-ID: <20231122211901.GJ38156@ZenIV> References: <20230816050803.15660-1-krisman@suse.de> <20231025-selektiert-leibarzt-5d0070d85d93@brauner> <655a9634.630a0220.d50d7.5063SMTPIN_ADDED_BROKEN@mx.google.com> <20231120-nihilismus-verehren-f2b932b799e0@brauner> <20231121022734.GC38156@ZenIV> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231121022734.GC38156@ZenIV> X-Headers-End: 1r5ucq-0000km-ER Subject: Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gabriel Krisman Bertazi , Christian Brauner , tytso@mit.edu, linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Nov 21, 2023 at 02:27:34AM +0000, Al Viro wrote: > I will review that series; my impression from the previous iterations > had been fairly unpleasant, TBH, but I hadn't rechecked since April > or so. The serious gap, AFAICS, is the interplay with open-by-fhandle. It's not unfixable, but we need to figure out what to do when lookup runs into a disconnected directory alias. d_splice_alias() will move it in place, all right, but any state ->lookup() has hung off the dentry that had been passed to it will be lost. And I seriously suspect that we want to combine that state propagation with d_splice_alias() (or its variant to be used in such cases), rather than fixing the things up afterwards. In particular, propagating ->d_op is really not trivial at that point; it is safe to do to ->lookup() argument prior to d_splice_alias() (even though that's too subtle and brittle, IMO), but after d_splice_alias() has succeeded, the damn thing is live and can be hit by hash lookups, revalidate, etc. The only things that can't happen to it are ->d_delete(), ->d_prune(), ->d_iput() and ->d_init(). Everything else is fair game. And then there's an interesting question about the interplay with reparenting. It's OK to return an error rather than reparent, but we need some way to tell if we need to do so. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel