From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: Restrict max filesize for 16K f2fs
Date: Fri, 1 Dec 2023 19:52:29 -0800 [thread overview]
Message-ID: <20231202035229.GA41173@sol.localdomain> (raw)
In-Reply-To: <20231202030347.2330936-1-drosen@google.com>
On Fri, Dec 01, 2023 at 07:03:47PM -0800, Daniel Rosenberg via Linux-f2fs-devel wrote:
> + /* For compatibility with 4K crypto unit size, we must restrict
> + * the max filesize to what can fit within U32_MAX 4K units.
> + * Since the blocksize must currently be equal to the page size,
> + * we can grab that from there. inode is NULL when setting up
> + * the superblock.
> + */
> +
> + result = min(result, ((loff_t) U32_MAX * 4096) >> PAGE_SHIFT);
This should be formatted like:
/*
* For compatibility with ...
*/
result = ...
Also, the comment should mention that this is for the IV_INO_LBLK_64 and
IV_INO_LBLK_32 encryption settings. There is no issue with the default
encryption setting.
Also, use F2FS_BLKSIZE_BITS instead of PAGE_SHIFT?
Also, the commit message could use:
Fixes: d7e9a9037de2 ("f2fs: Support Block Size == Page Size")
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2023-12-02 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 3:03 [f2fs-dev] [PATCH] f2fs: Restrict max filesize for 16K f2fs Daniel Rosenberg via Linux-f2fs-devel
2023-12-02 3:52 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231202035229.GA41173@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).