From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb
Date: Wed, 13 Dec 2023 09:41:23 +0100 [thread overview]
Message-ID: <20231213084123.GA6184@lst.de> (raw)
In-Reply-To: <20231213040018.73803-2-ebiggers@kernel.org>
On Tue, Dec 12, 2023 at 08:00:16PM -0800, Eric Biggers wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> blkdev_put must not be called under sb->s_umount to avoid a lock order
> reversal with disk->open_mutex once call backs from block devices to
> the file system using the holder ops are supported. Move the call
> to btrfs_close_devices into btrfs_free_fs_info so that it is closed
> from ->kill_sb (which is also called from the mount failure handling
> path unlike ->put_super) as well as when an fs_info is freed because
> an existing superblock already exists.
Thanks, this looks roughly the same to what I have locally.
I did in fact forward port everything missing from the get_super
series yesterday, but on my test setup btrfs/142 hangs even in the
baseline setup. I went back to Linux before giving up for now.
Josef, any chane you could throw this branch:
git://git.infradead.org/users/hch/misc.git btrfs-holder
into your CI setup and see if it sticks? Except for the trivial last
three patches this is basically what you reviewed already, although
there was some heavy rebasing due to the mount API converison.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-12-13 8:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 4:00 [f2fs-dev] [PATCH 0/3] Move fscrypt keyring destruction to after ->put_super Eric Biggers
2023-12-13 4:00 ` [f2fs-dev] [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb Eric Biggers
2023-12-13 8:41 ` Christoph Hellwig [this message]
2023-12-15 14:26 ` Josef Bacik
2023-12-15 21:45 ` Josef Bacik
2023-12-16 4:12 ` Christoph Hellwig
2023-12-16 14:52 ` Josef Bacik
2023-12-13 4:00 ` [f2fs-dev] [PATCH 2/3] f2fs: move release of block devices to after kill_block_super() Eric Biggers
2023-12-27 4:47 ` Eric Biggers
2023-12-27 7:10 ` Chao Yu
2023-12-13 4:00 ` [f2fs-dev] [PATCH 3/3] fs: move fscrypt keyring destruction to after ->put_super Eric Biggers
2023-12-13 16:15 ` Christoph Hellwig
2023-12-13 20:54 ` Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213084123.GA6184@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).