From: Eric Biggers <ebiggers@kernel.org>
To: linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/3] f2fs: move release of block devices to after kill_block_super()
Date: Tue, 26 Dec 2023 22:47:01 -0600 [thread overview]
Message-ID: <20231227044701.GC4240@quark.localdomain> (raw)
In-Reply-To: <20231213040018.73803-3-ebiggers@kernel.org>
On Tue, Dec 12, 2023 at 08:00:17PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Call destroy_device_list() and free the f2fs_sb_info from
> kill_f2fs_super(), after the call to kill_block_super(). This is
> necessary to order it after the call to fscrypt_destroy_keyring() once
> generic_shutdown_super() starts calling fscrypt_destroy_keyring() just
> after calling ->put_super. This is because fscrypt_destroy_keyring()
> may call into f2fs_get_devices() via the fscrypt_operations.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/f2fs/super.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Jaegeuk and Chao, when you have a chance can you review or ack this? I'm
thinking of taking patches 2-3 of this series through the fscrypt tree for 6.8.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-12-27 4:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 4:00 [f2fs-dev] [PATCH 0/3] Move fscrypt keyring destruction to after ->put_super Eric Biggers
2023-12-13 4:00 ` [f2fs-dev] [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb Eric Biggers
2023-12-13 8:41 ` Christoph Hellwig
2023-12-15 14:26 ` Josef Bacik
2023-12-15 21:45 ` Josef Bacik
2023-12-16 4:12 ` Christoph Hellwig
2023-12-16 14:52 ` Josef Bacik
2023-12-13 4:00 ` [f2fs-dev] [PATCH 2/3] f2fs: move release of block devices to after kill_block_super() Eric Biggers
2023-12-27 4:47 ` Eric Biggers [this message]
2023-12-27 7:10 ` Chao Yu
2023-12-13 4:00 ` [f2fs-dev] [PATCH 3/3] fs: move fscrypt keyring destruction to after ->put_super Eric Biggers
2023-12-13 16:15 ` Christoph Hellwig
2023-12-13 20:54 ` Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231227044701.GC4240@quark.localdomain \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).