From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [f2fs-dev] [PATCH] f2fs: avoid the deadlock case when stopping discard thread
Date: Tue, 19 Mar 2024 17:14:42 -0700 [thread overview]
Message-ID: <20240320001442.497813-1-jaegeuk@kernel.org> (raw)
f2fs_ioc_shutdown(F2FS_GOING_DOWN_NOSYNC) issue_discard_thread
- mnt_want_write_file()
- sb_start_write(SB_FREEZE_WRITE)
- sb_start_intwrite(SB_FREEZE_FS);
- f2fs_stop_checkpoint(sbi, false, : waiting
STOP_CP_REASON_SHUTDOWN);
- f2fs_stop_discard_thread(sbi);
- kthread_stop()
: waiting
- mnt_drop_write_file(filp);
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/segment.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 4fd76e867e0a..088b8c48cffa 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1923,7 +1923,9 @@ static int issue_discard_thread(void *data)
continue;
}
- sb_start_intwrite(sbi->sb);
+ /* Avoid the deadlock from F2FS_GOING_DOWN_NOSYNC. */
+ if (!sb_start_intwrite_trylock(sbi->sb))
+ continue;
issued = __issue_discard_cmd(sbi, &dpolicy);
if (issued > 0) {
--
2.44.0.291.gc1ea87d7ee-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2024-03-20 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 0:14 Jaegeuk Kim [this message]
2024-03-20 15:32 ` [f2fs-dev] [PATCH] f2fs: avoid the deadlock case when stopping discard thread Chao Yu
2024-03-21 22:42 ` Hillf Danton
2024-03-22 0:29 ` Jaegeuk Kim
2024-03-22 11:33 ` Hillf Danton
[not found] ` <SI2PR03MB52607606AB0D29C8AB123C1484312@SI2PR03MB5260.apcprd03.prod.outlook.com>
2024-03-22 22:24 ` [f2fs-dev] 回覆: " Jaegeuk Kim
2024-03-26 16:52 ` Jaegeuk Kim
[not found] ` <SI2PR03MB526041E42B6BD9C9DA9FBAC184352@SI2PR03MB5260.apcprd03.prod.outlook.com>
[not found] ` <SI2PR03MB5260819B5B1719063EFF458A843D2@SI2PR03MB5260.apcprd03.prod.outlook.com>
2024-04-04 19:55 ` [f2fs-dev] 回覆: " Jaegeuk Kim
[not found] ` <SI2PR03MB52608626CE591F850F5F815384042@SI2PR03MB5260.apcprd03.prod.outlook.com>
2024-04-12 20:50 ` [f2fs-dev] 回覆: " Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320001442.497813-1-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).