From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-mips@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-crypto@vger.kernel.org, loongarch@lists.linux.dev,
sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-ext4@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [f2fs-dev] [PATCH v2 15/18] ext4: switch to using the crc32c library
Date: Sat, 2 Nov 2024 15:26:35 -0700 [thread overview]
Message-ID: <20241102222635.GB455688@mit.edu> (raw)
In-Reply-To: <20241025191454.72616-16-ebiggers@kernel.org>
On Fri, Oct 25, 2024 at 12:14:51PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Now that the crc32c() library function directly takes advantage of
> architecture-specific optimizations, it is unnecessary to go through the
> crypto API. Just use crc32c(). This is much simpler, and it improves
> performance due to eliminating the crypto API overhead.
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Theodore Ts'o <tytso@mit.edu>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-11-05 13:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 19:14 [f2fs-dev] [PATCH v2 00/18] Wire up CRC32 library functions to arch-optimized code Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 01/18] lib/crc32: drop leading underscores from __crc32c_le_base Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 02/18] lib/crc32: improve support for arch-specific overrides Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 03/18] lib/crc32: expose whether the lib is really optimized at runtime Eric Biggers via Linux-f2fs-devel
2024-10-25 20:32 ` Ard Biesheuvel via Linux-f2fs-devel
2024-10-25 21:32 ` Eric Biggers via Linux-f2fs-devel
2024-10-25 21:37 ` Ard Biesheuvel via Linux-f2fs-devel
2024-10-25 22:31 ` Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms Eric Biggers via Linux-f2fs-devel
2024-10-25 20:47 ` Ard Biesheuvel via Linux-f2fs-devel
2024-10-25 22:02 ` Eric Biggers via Linux-f2fs-devel
2024-10-26 4:09 ` Eric Biggers via Linux-f2fs-devel
2024-10-27 8:14 ` Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 9:45 ` Herbert Xu via Linux-f2fs-devel
2024-11-02 9:58 ` Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 10:19 ` Herbert Xu via Linux-f2fs-devel
2024-11-02 10:46 ` Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 11:05 ` Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 11:08 ` Herbert Xu via Linux-f2fs-devel
2024-11-02 16:36 ` Eric Biggers via Linux-f2fs-devel
2024-11-02 16:46 ` Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 17:21 ` Milan Broz
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 05/18] arm/crc32: expose CRC32 functions through lib Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 06/18] loongarch/crc32: " Eric Biggers via Linux-f2fs-devel
2024-11-03 13:36 ` WangYuli
2024-11-03 13:57 ` Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 07/18] mips/crc32: " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 08/18] powerpc/crc32: " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 09/18] s390/crc32: " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 10/18] sparc/crc32: " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 11/18] x86/crc32: update prototype for crc_pcl() Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 12/18] x86/crc32: update prototype for crc32_pclmul_le_16() Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 13/18] x86/crc32: expose CRC32 functions through lib Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 14/18] lib/crc32: make crc32c() go directly to lib Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 15/18] ext4: switch to using the crc32c library Eric Biggers via Linux-f2fs-devel
2024-11-02 22:26 ` Theodore Ts'o [this message]
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 16/18] jbd2: " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 17/18] f2fs: switch to using the crc32 library Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [f2fs-dev] [PATCH v2 18/18] scsi: target: iscsi: switch to using the crc32c library Eric Biggers via Linux-f2fs-devel
2024-10-25 22:14 ` Ard Biesheuvel via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241102222635.GB455688@mit.edu \
--to=tytso@mit.edu \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).