From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 040A2D1BDD4 for ; Mon, 4 Nov 2024 17:48:55 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t81C9-0004cY-H5; Mon, 04 Nov 2024 17:48:54 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t81C7-0004cR-Pq for linux-f2fs-devel@lists.sourceforge.net; Mon, 04 Nov 2024 17:48:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jOpQChbady85VjphGfbgQ0josSjOZ9BtFVZ3HbNMAFc=; b=Ht+scuJ1QyZhjAHdP69QseJqei o2pFY5RihhfsFQZ4SgRIhSAKI+XXux7Ayf5I3Ph68GVTdFcmf4m/05MK+vUaD6QNnfvMFxdSPpCNC eMSRkeEgqskCX5Uu3/XLIJkJ0OXApkBWrEMYoKf6+iPuJH9T9BzTpFeq+Glmp7UDkkRw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jOpQChbady85VjphGfbgQ0josSjOZ9BtFVZ3HbNMAFc=; b=S9lE+Q/WHsUFYMA2Nj/c+KuNW7 /AeVJzN41KSRtqiudclv1EujAv7bjqXLLZYTeMDS1m1bGrAqVMGhx747WJH3Idq/rPPl4NkbPEr5v lRMkrwejqeWZKySovmOLjgJ5+dZP4odeM0W4Q2tMBFxjJ+aGIzo6kmXUEZm+QMXyqpeg=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1t81C7-0004Uu-T1 for linux-f2fs-devel@lists.sourceforge.net; Mon, 04 Nov 2024 17:48:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0EB5EA431F6; Mon, 4 Nov 2024 17:46:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1421C4CECE; Mon, 4 Nov 2024 17:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730742520; bh=kyMZ9fV6X+51trgRY65w1AUDjMP2XEnEX7GkvQFyuQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RG0ZZ45eSLTeSuURvGHB3h65F9t7QbkI04hRi4PIn9RQya+KVuOq+cKYwcM7OIRag ftffa9p0RPzhxKxbKbO1phJPPDnrPKDiu3Z4Itvr9Wls0R3DzSPdYDwIWB6GC4b2Kn OEWSQb/cisXjv+NDzmcx6uuXNdVsmOSyH1jBzLk86RwIVvV7yoI0yJMI8N5O1tLxWZ sqPAibypRsiDduXZx2vz4SdLoEWaYuAYo/l7nO/C5PoaF6LQixrBB1eQNUAosrKHye /gCeCfoWgbjXS3QMM1TfccoGnuhihV/zkZVDdun5Dof7x1e0ZdWeQe1z6JZskIC3qV 2uU8b6EJ5uv3w== Date: Mon, 4 Nov 2024 17:48:39 +0000 To: "Darrick J. Wong" Message-ID: <20241104174839.GA1049313@google.com> References: <20241103223154.136127-1-ebiggers@kernel.org> <20241103223154.136127-16-ebiggers@kernel.org> <20241104155900.GH21832@frogsfrogsfrogs> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241104155900.GH21832@frogsfrogsfrogs> X-Headers-End: 1t81C7-0004Uu-T1 Subject: Re: [f2fs-dev] [PATCH v3 15/18] ext4: switch to using the crc32c library X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mips@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-ext4@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Nov 04, 2024 at 07:59:00AM -0800, Darrick J. Wong wrote: > Hmm. Looking at your git branch (which was quite helpful to link to!) I > think for XFS we don't need to change the crc32c() calls, and the only > porting work that needs to be done is mirroring this Kconfig change? > And that doesn't even need to be done until someone wants to get rid of > CONFIG_LIBCRC32C, right? That's correct, no porting work is required now. 'select LIBCRC32C' should be replaced with 'select CRC32', but that can be done later. > > @@ -3278,15 +3263,11 @@ extern void ext4_group_desc_csum_set(struct super_block *sb, __u32 group, > > extern int ext4_register_li_request(struct super_block *sb, > > ext4_group_t first_not_zeroed); > > > > static inline int ext4_has_metadata_csum(struct super_block *sb) > > { > > - WARN_ON_ONCE(ext4_has_feature_metadata_csum(sb) && > > - !EXT4_SB(sb)->s_chksum_driver); > > - > > - return ext4_has_feature_metadata_csum(sb) && > > - (EXT4_SB(sb)->s_chksum_driver != NULL); > > + return ext4_has_feature_metadata_csum(sb); > > } > > Nit: Someone might want to > s/ext4_has_metadata_csum/ext4_has_feature_metadata_csum/ here to get rid > of the confusingly named trivial helper. > Yes, that should be done as a follow-up patch. > Otherwise this logic looks ok to me, so > Reviewed-by: Darrick J. Wong > > --D Thanks, - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel