* [f2fs-dev] [PATCH] mkfs.f2fs: remove IMMUTABLE bit
@ 2024-11-11 3:04 Jaegeuk Kim via Linux-f2fs-devel
2024-11-11 17:07 ` Daeho Jeong
2024-11-18 1:24 ` Chao Yu via Linux-f2fs-devel
0 siblings, 2 replies; 3+ messages in thread
From: Jaegeuk Kim via Linux-f2fs-devel @ 2024-11-11 3:04 UTC (permalink / raw)
To: linux-f2fs-devel; +Cc: Jaegeuk Kim
The immutable bit disallows selinux permission which gives no way to clear it.
Fixes: 8cc4e257ec20 ("mkfs.f2fs: add device aliasing feature")
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
mkfs/f2fs_format.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
index 52a1e1864b29..6635eed99813 100644
--- a/mkfs/f2fs_format.c
+++ b/mkfs/f2fs_format.c
@@ -1748,8 +1748,7 @@ static int f2fs_write_alias_inodes(void)
dev_off++;
f2fs_init_inode(sb, raw_node, ino, mkfs_time, 0x81c0);
- raw_node->i.i_flags = cpu_to_le32(F2FS_IMMUTABLE_FL |
- F2FS_DEVICE_ALIAS_FL);
+ raw_node->i.i_flags = cpu_to_le32(F2FS_DEVICE_ALIAS_FL);
raw_node->i.i_inline = F2FS_PIN_FILE;
raw_node->i.i_pino = sb->root_ino;
filename = c.devices[i].alias_filename;
--
2.47.0.277.g8800431eea-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH] mkfs.f2fs: remove IMMUTABLE bit
2024-11-11 3:04 [f2fs-dev] [PATCH] mkfs.f2fs: remove IMMUTABLE bit Jaegeuk Kim via Linux-f2fs-devel
@ 2024-11-11 17:07 ` Daeho Jeong
2024-11-18 1:24 ` Chao Yu via Linux-f2fs-devel
1 sibling, 0 replies; 3+ messages in thread
From: Daeho Jeong @ 2024-11-11 17:07 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel
Reviewed-by: Daeho Jeong <daehojeong@google.com>
Thanks,
On Sun, Nov 10, 2024 at 7:09 PM Jaegeuk Kim via Linux-f2fs-devel
<linux-f2fs-devel@lists.sourceforge.net> wrote:
>
> The immutable bit disallows selinux permission which gives no way to clear it.
>
> Fixes: 8cc4e257ec20 ("mkfs.f2fs: add device aliasing feature")
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> mkfs/f2fs_format.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> index 52a1e1864b29..6635eed99813 100644
> --- a/mkfs/f2fs_format.c
> +++ b/mkfs/f2fs_format.c
> @@ -1748,8 +1748,7 @@ static int f2fs_write_alias_inodes(void)
> dev_off++;
> f2fs_init_inode(sb, raw_node, ino, mkfs_time, 0x81c0);
>
> - raw_node->i.i_flags = cpu_to_le32(F2FS_IMMUTABLE_FL |
> - F2FS_DEVICE_ALIAS_FL);
> + raw_node->i.i_flags = cpu_to_le32(F2FS_DEVICE_ALIAS_FL);
> raw_node->i.i_inline = F2FS_PIN_FILE;
> raw_node->i.i_pino = sb->root_ino;
> filename = c.devices[i].alias_filename;
> --
> 2.47.0.277.g8800431eea-goog
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH] mkfs.f2fs: remove IMMUTABLE bit
2024-11-11 3:04 [f2fs-dev] [PATCH] mkfs.f2fs: remove IMMUTABLE bit Jaegeuk Kim via Linux-f2fs-devel
2024-11-11 17:07 ` Daeho Jeong
@ 2024-11-18 1:24 ` Chao Yu via Linux-f2fs-devel
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2024-11-18 1:24 UTC (permalink / raw)
To: Jaegeuk Kim, linux-f2fs-devel
On 2024/11/11 11:04, Jaegeuk Kim via Linux-f2fs-devel wrote:
> The immutable bit disallows selinux permission which gives no way to clear it.
>
> Fixes: 8cc4e257ec20 ("mkfs.f2fs: add device aliasing feature")
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-18 1:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-11 3:04 [f2fs-dev] [PATCH] mkfs.f2fs: remove IMMUTABLE bit Jaegeuk Kim via Linux-f2fs-devel
2024-11-11 17:07 ` Daeho Jeong
2024-11-18 1:24 ` Chao Yu via Linux-f2fs-devel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).